Open
Conversation
Rewriting argument parsing allows us to succinctly parse three different arguments with the same overall shape. We'll need that capability shortly.
When the `#[async_generic]` macro has a `sync_cfg(...)` argument, the parameters to that argument are passed into a `#[cfg(...)]` block for the sync version of the function. When the `#[async_generic]` macro has an `async_cfg(...)` argument, the parameters to that argument are passed into a `#[cfg(...)]` block for the async version of that function. Together, this gives users complete control over which versions of the functions are compiled, when.
One test each (the passing tests) demonstrate that items which should be retained are in fact retained. One test each (the failing tests) demonstrate that items which should be omitted are in fact omitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to conditionally compile sync or async versions of the emitted functions, with arbitrary conditions.
Closes #18.