FIx Issue 44 and MInor change to the Readme file#91
Open
ChakshuGupta wants to merge 4 commits intoscorelab:masterfrom
Open
FIx Issue 44 and MInor change to the Readme file#91ChakshuGupta wants to merge 4 commits intoscorelab:masterfrom
ChakshuGupta wants to merge 4 commits intoscorelab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installation steps mentioned in the Readme file were -
cd ChainKeeper
npm install
npm start
The problem was that the main ChainKeeper directory doesn't contain the package.json file. It is inside the ChainKeeper/chainkeeper_app/. So I updated the Readme to reflect the same.
Added fsevents as an optional dependency in the package.json file to keep the npm install from giving errors.