refactor: use bytesize and parse-display #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Oct 11, 2025
| .unwrap() | ||
| FoyerEngine::try_new( | ||
| dir.path(), | ||
| ByteSize::default(), |
tisonkun
commented
Oct 11, 2025
| env_name: "PERCAS_CONFIG_STORAGE_DISK_CAPACITY", | ||
| ent_path: "storage.disk_capacity", | ||
| ent_type: "integer", | ||
| ent_type: "string", |
Contributor
Author
There was a problem hiding this comment.
ByteSize can accept "1234" as bytes. So this change is not breaking.
tisonkun
commented
Oct 11, 2025
| } | ||
|
|
||
| let mut db = FsDeviceBuilder::new(data_dir).with_capacity(disk_capacity as usize); | ||
| let mut db = FsDeviceBuilder::new(data_dir).with_capacity(disk_capacity.0 as usize); |
Contributor
Author
There was a problem hiding this comment.
@MrCroxx Entrypoint that foyer can use bytesize.
Contributor
Author
There was a problem hiding this comment.
But foyer may not want to add an external dep in the public API. Let me think of the boundary ...
tisonkun
commented
Oct 11, 2025
| BlockEngineBuilder::new(dev) | ||
| .with_recover_concurrency(parallelism) | ||
| .with_block_size(DEFAULT_BLOCK_SIZE) | ||
| .with_block_size(DEFAULT_BLOCK_SIZE.0 as usize) |
Contributor
Author
There was a problem hiding this comment.
@MrCroxx Entrypoint that foyer can use bytesize.
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
bytesize-everywhere
branch
from
f8dcc36 to
111b32a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.