Properly detect missing authorization in Outcalls using OAuth#591
Merged
jmuscireum merged 1 commit intomainfrom Jan 15, 2026
Merged
Properly detect missing authorization in Outcalls using OAuth#591jmuscireum merged 1 commit intomainfrom
jmuscireum merged 1 commit intomainfrom
Conversation
403 is the wrong code to check, as it indicated missing permissions. 401 indicates missing authorization and is also the code that our own services return. Fixes: SE-14765
sabieber
approved these changes
Jan 15, 2026
mkeckmkeck
approved these changes
Jan 15, 2026
jakobvogel
approved these changes
Jan 15, 2026
fhaScireum
approved these changes
Jan 15, 2026
idlira
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
403 is the wrong code to check, as it indicated missing permissions. 401 indicates missing authorization and is also the code that our own services return.
Additional Notes
Checklist