Skip to content

Improves the ParallelTaskExecutor#586

Merged
idlira merged 4 commits intodevelopfrom
ili/OX-12263
Dec 5, 2025
Merged

Improves the ParallelTaskExecutor#586
idlira merged 4 commits intodevelopfrom
ili/OX-12263

Conversation

@idlira
Copy link
Contributor

@idlira idlira commented Dec 4, 2025

Description

  • Fix a bug where the internal executor were not closed when the task context was no longer active, resulting in the submitted tasks to run until the end even when the "parent" already closed.
  • Permits to override how to check if the process is still active, other than the default TaskContext.get().isActive.

Additional Notes

  • This PR fixes or works on following ticket(s): OX-12263

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices

idlira added 3 commits December 4, 2025 15:53
@idlira
Closes the executor in the right place
7845d86 
Fixes: OX-12263
@idlira
Uses unnamed variable where not used
a0bb3ef 
Fixes: OX-12263
@idlira
Permits to override when the executor must stop
ce54349 
By default, we check if the current TaskContext is active, but more complex scenarios might require additional checks.

Fixes: OX-12263
@idlira idlira added 🐛 Bugfix Contains only a small fix for an existing bug 🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review labels Dec 4, 2025
@idlira
Covers for RejectedExecutionException
d297728 
if something is submitted after the executor have been closed.

For cleanliness, empty the queue at the end.

Fixes: OX-12263
@idlira idlira merged commit 2b3f063 into develop Dec 5, 2025
4 checks passed
@idlira idlira deleted the ili/OX-12263 branch December 5, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ymo-sci ymo-sci ymo-sci left review comments

@sabieber sabieber sabieber approved these changes

@jmuscireum jmuscireum jmuscireum approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@mkeckmkeck mkeckmkeck mkeckmkeck approved these changes

Assignees

No one assigned

Labels

🐛 Bugfix Contains only a small fix for an existing bug 🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@idlira @sabieber @jmuscireum @jakobvogel @fhaScireum @ymo-sci @mkeckmkeck