Adds an explicit constant to better document behavior#581
Merged
Conversation
Outcall.modifyClient(String) accepts a string to cache a newly constructed HttpClient. null is used to signal that the client must not be cached. To better document this, an explicit constant was added so that call.modifyClient(Outcall.CLIENT_SELECTOR_NO_CACHE) sort of speaks for itself (in contrast to call.modifyClient(null)
andyHa
added
👶🏻 Trivial
sabieber
approved these changes
Nov 21, 2025
idlira
approved these changes
Nov 21, 2025
jakobvogel
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Outcall.modifyClient(String) accepts a string to cache a newly constructed HttpClient. null is used to signal that the client must not be cached. To better document this, an explicit constant was added so that
call.modifyClient(Outcall.CLIENT_SELECTOR_NO_CACHE)sort of speaks for itself (in contrast tocall.modifyClient(null))Additional Notes
Checklist