Add LOKI wire view and extend transform signature to include source_name #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the logical view transform signature from (da) -> da to
(da, source_name) -> da. This allows a single transform function to
handle multiple detector banks with different parameters (e.g., different
fold sizes based on the detector bank).
Add wire view for LOKI that sums over 'straw' and 'pixel' dimensions,
resulting in a 2D (layer x tube) output. This is appropriate because all
7 straws share a single electrical readout. The view uses
DETECTOR_BANK_SIZES from ess.loki.workflow which has pixel=-1 for
auto-computation.
Also update DREAM views to use source_name for lookup in DETECTOR_BANK_SIZES.
Prompt: We now need to add a wire-view for LOKI. We should use
ess.loki.workflow.DETECTOR_BANK_SIZES and support loki_detector_{i} for
i=0...8; As all 7 straws have a single readout (same electrical component),
I think we should sum the 'straw' as well as the 'pixel' dimension,
resulting in a 2d output.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This is typically yielding unwanted and even unreadable results (large empty padding, compressed color scales).
jl-wynen
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(da) -> dato(da, source_name) -> da, allowing transforms to handle multiple detector banks with different parametershv.Layoutplots to prevent compressed/unreadable displays when showing multiple detector banksPlotting all 9 banks this looks like this:
Test plan
🤖 Generated with Claude Code