-
Notifications
You must be signed in to change notification settings - Fork 36
test on free‑threaded Python #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Saransh-cpp numba does not yet support free-threaded python FYI. I think they plan to do it in their next release. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
=======================================
Coverage 86.70% 86.70%
=======================================
Files 96 96
Lines 11221 11221
=======================================
Hits 9729 9729
Misses 1492 1492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I see that Numba is not fully available on python 3.14t yet. @henryiii is there a neat way to exclude the installation of Numba when running on Python 3.14t? Or should I just manipulate the dependency-groups and isolate Numba as a stand-alone dependency-group (making them a bit ugly but functional). Edit: Thanks, @ikrommyd! Yes, I realised that. There is no metadata marker to exclude dependencies from a specific build of Python; hence, I do have an ugly fix in mind, but I wanted to check if there is a more elegant way to do this. |
|
Yes, no elegant way, sadly. There needs to be a new marker, and they want to have a more elegant solution than just a free-threading specific marker, so it pretty much stalled AFAIK. Numba does technically support 3.14t now, but only preliminary and no wheels as far as I know. numba/numba#9928 |
|
Yeah I knew there are no wheels and hence why I approved the other PR. I did not consider free-threaded builds since I knew vector depends on numba. Should have been more careful since it is not a strict dependency. |
|
This should now be ready for a review. |
|
Good to see that no test failures popped up. |
|
Should we add a free-threading classifier? :) |
|
Ooh yes, sounds nice. I've added the |
ianna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saransh-cpp - this looks great! Thanks for adding it.
Description
Following #675, this PR adds test for free-threaded Python 3.14
Checklist
$ pre-commit run --all-filesor$ nox -s lint)$ pytestor$ nox -s tests)$ cd docs; make clean; make htmlor$ nox -s docs)$ pytest --doctest-plus src/vector/or$ nox -s doctests)Before Merging