Skip to content

Conversation

@Saransh-cpp
Copy link
Member

@Saransh-cpp Saransh-cpp commented Jan 5, 2026

Description

Following #675, this PR adds test for free-threaded Python 3.14

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Requests for the required change?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission pass the doctests? ($ pytest --doctest-plus src/vector/ or $ nox -s doctests)

Before Merging

  • Summarize the commit messages into a brief review of the Pull request.

@Saransh-cpp Saransh-cpp marked this pull request as ready for review January 5, 2026 14:24
@Saransh-cpp Saransh-cpp requested review from henryiii and ianna January 5, 2026 14:24
@ikrommyd
Copy link

ikrommyd commented Jan 5, 2026

@Saransh-cpp numba does not yet support free-threaded python FYI. I think they plan to do it in their next release.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.70%. Comparing base (fd1a553) to head (4c83a86).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   86.70%   86.70%           
=======================================
  Files          96       96           
  Lines       11221    11221           
=======================================
  Hits         9729     9729           
  Misses       1492     1492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Saransh-cpp
Copy link
Member Author

Saransh-cpp commented Jan 5, 2026

I see that Numba is not fully available on python 3.14t yet. @henryiii is there a neat way to exclude the installation of Numba when running on Python 3.14t? Or should I just manipulate the dependency-groups and isolate Numba as a stand-alone dependency-group (making them a bit ugly but functional).

Edit: Thanks, @ikrommyd! Yes, I realised that. There is no metadata marker to exclude dependencies from a specific build of Python; hence, I do have an ugly fix in mind, but I wanted to check if there is a more elegant way to do this.

@henryiii
Copy link
Member

henryiii commented Jan 5, 2026

Yes, no elegant way, sadly. There needs to be a new marker, and they want to have a more elegant solution than just a free-threading specific marker, so it pretty much stalled AFAIK.

Numba does technically support 3.14t now, but only preliminary and no wheels as far as I know. numba/numba#9928

@ikrommyd
Copy link

ikrommyd commented Jan 5, 2026

Yeah I knew there are no wheels and hence why I approved the other PR. I did not consider free-threaded builds since I knew vector depends on numba. Should have been more careful since it is not a strict dependency.

@Saransh-cpp
Copy link
Member Author

This should now be ready for a review.

@ikrommyd
Copy link

ikrommyd commented Jan 5, 2026

Good to see that no test failures popped up.

@henryiii
Copy link
Member

henryiii commented Jan 5, 2026

Should we add a free-threading classifier? :)

@Saransh-cpp
Copy link
Member Author

Ooh yes, sounds nice. I've added the Programming Language :: Python :: Free Threading :: 3 - Stable classifier. Thanks!

Copy link
Member

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saransh-cpp - this looks great! Thanks for adding it.

@Saransh-cpp Saransh-cpp merged commit 4ba12d8 into main Jan 5, 2026
21 checks passed
@Saransh-cpp Saransh-cpp deleted the saransh/3.14t branch January 5, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants