Skip to content

TST: Catch ResourceWarning under bad combo #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsipocz merged 4 commits into from
Oct 20, 2025
+10 −2
Merged

TST: Catch ResourceWarning under bad combo #307

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1572b49
TST: Catch ResourceWarning under bad combo
pllim Oct 20, 2025
acf6ea7
Fix indent
pllim Oct 20, 2025
42d37ff
TST: Relax warning ignore
pllim Oct 20, 2025
7f1568c
Move ignore to the correct line
pllim Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/test_doctestplus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import glob
import os
import sys
import warnings
from platform import python_version
from textwrap import dedent
import sys

from packaging.version import Version

Expand All @@ -25,6 +26,7 @@


PYTEST_LT_6 = Version(pytest.__version__) < Version('6.0.0')
PYTEST_LT_8_5 = Version(pytest.__version__) < Version('8.5.0.dev')


def test_ignored_whitespace(testdir):
Expand Down Expand Up @@ -730,7 +732,13 @@ def f():
testdir.makefile('.rst', foo='>>> 1+1\n2')

testdir.inline_run('--doctest-plus').assertoutcome(passed=2)
testdir.inline_run('--doctest-plus', '--doctest-rst').assertoutcome(passed=3)
if os.name == "nt" and python_version() == "3.14.0" and not PYTEST_LT_8_5:
with warnings.catch_warnings():
# ResourceWarning unclosed file pytest.EXE --> PytestUnraisableExceptionWarning
warnings.filterwarnings("ignore")
Copy link
Member

@bsipocz bsipocz Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may be a bit too wide, but there are so many conditions it needs to catch that I don't mind it much.

Copy link
Contributor Author

@pllim pllim Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to catch ResourceWarning specifically but it didn't work. Catching PytestUnraisableExceptionWarning is a little meaningless.

testdir.inline_run('--doctest-plus', '--doctest-rst').assertoutcome(passed=3)
else:
testdir.inline_run('--doctest-plus', '--doctest-rst').assertoutcome(passed=3)
testdir.inline_run(
'--doctest-plus', '--doctest-rst', '--ignore', '.'
).assertoutcome(passed=0)
Expand Down