-
Notifications
You must be signed in to change notification settings - Fork 42
CI: adding Python 3.14 for testing #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ahh, windows is giving me tears again 😭 |
|
Could this be upstream bug? I tried to look at pytest code but then I got confused because it has both |
|
pytest does have a passing Windows job for Python 3.14 but not sure about its coverage. |
|
I think it's something going wrong with the skip logic, at least some of those are tests that should have been skipped, see that the math is correct, but we expected the wrong value. |
|
I think these are the offending checks? I don't see any skip directive. pytest-doctestplus/tests/test_doctestplus.py Line 775 in 57d68be
pytest-doctestplus/tests/test_doctestplus.py Line 781 in 57d68be
I also see this at the end. Maybe this is the real reason?
|
|
Ahh, then these are the culprits, it should have been picked up for asserting the outcome. I indeed wonder if the file creation was messed up? |
|
Let's ping our old friend @nicoddemus in case he is aware of such problem upstream with Python 3.14 + Windows, or can point us somewhere? 🙏 |
|
Hi folks, Nothing specific comes to mind. One option I guess is to ignore that Sorry I can't be more helpful. |
pllim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
No description provided.