implemented pytest for makepyfile

[d-chris]

see: fixture testdir.makepyfile does not encode files properly #285

hopefully the tests will show there is something odd, and someone can fix it

run pytests:

pytest tests\test_makepyfile.py::test_compare_make_basic_file

[pllim]

Note for other reviewers: See https://github.com/scientific-python/pytest-doctestplus/pull/286/files#r2004356445

[d-chris]

set env variable PYTEST_DEBUG_MAKEPYFILE to run test function

[pllim]

Thanks for adding the tests! Some comments posted and hopefully more eyes can look at this.

[d-chris]

in my generated test content i discovered a bug which i fixed in ef57b66

also debug tests are skipped in CI enable with env PYTEST_DEBUG_MAKEPYFILE c8f55a2

[d-chris]

@bsipocz you don' t have to run the CI, test are still failing

somehow makepyfile uses not the given encoding utf-16.

I don't know if further debugging makes any sense. I guess testdir is a legacy feature and should no longer be used.

FAILED tests/test_makepyfile.py::test_compare_write_bytes[utf_16-letters] - AssertionError: makepyfile screwed up encoding='utf_16' and raised error=UnicodeDecodeError('utf-8', b"\xff\xfe\n\x00d\x00e\x00f\x00 \x00f\x00(\x00)\x00:\x00\n\x00 \x00 \x00 \x00 \x00'\x00'\x00'\x00\n\x00 \x00 \x00 \x00 \x00>\x00>\x00>\x00 \x00p\x00r\x00i\x00n\x00t\x00(\x00'\x00A\x00'\x00)\x00\n\x00 \x00 \x00 \x00 \x00B\x00\n\x00 \x00 \x00 \x00 \x00'\x00'\x00'\x00\n\x00 ...

[bsipocz]

Ahh, OK. I suppose I was pushing the buttons faster than I was reading the comments ;)

[d-chris]

problem is located in pytest, guess have to open an issue there.

nothing we can do, except dont use fixture testdir.makepyfile when encoding is required

pytets

required fix is unpack args and kwargs: return self._makefile(".py", *args, **kwargs)

usage

files is a positional argument and then has to be passed on

make_file = testdir.makepyfile(
    bytes_content,
    files={},
    encoding=encoding,
)

[bsipocz]

Upstream basically said not to do this, so I'm closing the PR as Christoph suggested.

Thanks for all the work you put in the investigation!