Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds parallel processing to the DataProcessor part of PulsarFeatureLab. Clearly processing multiple files is embarrassingly parallel, so this does not take much work. Using multiprocessing means the code inside DataProcessor needs to be refactored a bit, but since all the processing code is encapsulated in the candidate class no changes need to be made to this.
On a machine with multiple cores, the speedup given by this change is pretty good: processing 11,000,000 htru2 datafiles with 32 cores took almost 16 hours with the current code, whereas this fork reduces this to more like 2 and a half.
On the negative side, as it stands it makes the exception reporting slightly less good: it can report the file where the exception occurred and the type of exception, but I haven't implemented a way to print a full stack trace as before.
Also, since multiprocessing is new in python 2.6, this would raise the requirements for this program from python 2.4 to 2.6. Given that 2.7 is standard on most distributions these days this shouldn't be too much of a problem.
Finally, some functions had to be moved outside the class because multiprocessing is only able to deal with pickle-able objects. This is slightly less neat but I don't really think it hurts the clarity of the code.