AIS backtick bug fix. #206
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with 6-bit ascii spec.
Owner
|
Thanks for making a pull request! Sorry I'm so slow at responding to libais issues and prs. Are you sure about this? I would like that very little of libais would work if this part of the code is incorrect. A test case that works only after this fix would help convince me. |
The visual resemblance to a backtick (`) in some document printings is purely a typographic artifact. This distinction is critical because:
AIS 6-bit ASCII subset explicitly includes 0x27 (single quote) but excludes 0x60 (backtick).
Protocol compliance: Using a backtick would render the AIS message invalid, while the single quote is fully compliant.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces ais bitset backtick with escaped single-quote in accordance with 6bit ASCII spec (Dec. 39 should be ' but was `).