Noaa dma test #16
Open
Noaa dma test #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ctest commands to generate test target in makefile. Renamed tests to eliminate underscores, since they shouldn't be used according to gtest documentation. Made test targets optional as well as the choice between a single giant test or smaller individual tests. Conflicts: CMakeLists.txt
(Back ported to branch tracking schwehr/libais) Conflicts: ais8_001_22_unittest.cpp
schwehr
added a commit
that referenced
this pull request
Nov 27, 2017
- Changed the circle accessors to match the new style - ASSERT_ to EXPECT_ for most places - 8_001_22 -> 8_1_22 - Some troubles with the polygon that need to be investigated - _EQ -> _DOUBLE_EQ - const -> constexpr - STREQ -> EQ for std::string - Fixed formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test passes in my dev branch, but fails in your master.
The bug was fixed here:
rolker@769fa0f
I know that wasn't a small digestible commit like you would prefer, but doesn't an actual bug fix override a less than perfect commit?