Open
Conversation
…ated README and added LICENSE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Leo (and GW)!
ClumPyCells is a wonderful tool in the spatial analysis ecosystem, but I personally found a little bit of friction while working with the package. I took the creative liberty to make it into a proper Python package, but feel free to take administration in making certain changes. In fact, the main reason why I wanted to package it in the first place was because I wanted to use it for my own analysis. Before editing or merging the PR, I highly recommend testing the package by re-running your analysis (as I was unable to import this package, see comments below).
Comments
pip install .from the base directory. Once you publish to PyPi, you can change the command topip install ClumPyCellsconfig.jsoninAnalysis/metadata.py, which may pose issues for future users (since they don't have access to that file). I'm sure you have noted it already, but just commenting it here to remind you.Publishing on PyPi
If you haven't worked with the PyPi ecosystem before, I recommend following these tutorial steps. It is extremely simple, as you just need to
python -m buildtwine upload --repository pypi dist/*