action type definition improvement#91
Open
aschiavon91 wants to merge 1 commit intoschrockwell:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, firstly, thanks for awesome work!
I do like to expand the type definition of the action type a little.
I use policies tided to the controller/action, and I do that, configuring bodyguard to call a module/func to retrieve the current controller/action.
It's working pretty nicely, but after I bumped one of my projects to elixir 1.18, elixir-ls starts complaining about the expected type in the
authorizecallback.Maybe, we can change it to any(), but IMHO, it's not necessary because any() make type specs too lazy.