Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request attempts to resolve issue #8.
The problem
The behavior of pj_dump parser was to ignore any quotes. For example, the content of this file (links.trace):
would be dumped as follows by
pj_dump:It is possible to see that even though there is quotes in the definitions ("PROCESS", "LINK", "p1", "p2" and "p3"), the quotes vanished (were ignored) when parsed by the standard pj_dump parser. This behavior caused the problem seen on issue #8. By using the flex parser option
--flex, the quotes are not ignored, meaning that the quotes presents in the pj file definition are still there after the pj_dump, to exemplify here is the output ofpj_dump --flex links.trace:It is possible to see that the quotes weren't ignored this time, and because of this it worked as workaround to solve this problem.
Changes made
As I think that makes sense to keep the quotes when it appears in the paje file, this pull request make small changes in the event decoder in order to the output to keep the quotes.
It was necessary to change the test also, because the tests results also expected the quotes to be ignored. So I used the current version with the
--flexoption to replace the output of the tests by the one that didn't ignore the quotes.