Fix segmentation fault on macOS ARM64 with Clang 19#38
Open
firilisinof wants to merge 1 commit intoschnorr:masterfrom
Open
Fix segmentation fault on macOS ARM64 with Clang 19#38firilisinof wants to merge 1 commit intoschnorr:masterfrom
firilisinof wants to merge 1 commit intoschnorr:masterfrom
Conversation
This commit fixes two issues causing crashes on modern macOS systems with Clang 19: 1. Add virtual destructor to PajeEntity class - Prevents undefined behavior when deleting derived objects through base pointers - Resolves -Wdelete-abstract-non-virtual-dtor compiler warnings 2. Fix dangling iterator in valuesForEntityType - Store container returned by values() before iterating - Prevents iteration over destroyed temporary object - Resolves -Wdangling-gsl compiler warning These issues manifest as segmentation faults on Apple Silicon Macs with Clang 19.1.7. It modifies src/tools/CMakeLists.txt to compile correctly in Apple systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue #37. The commit fixes two issues causing crashes on modern macOS systems with Clang 19:
These issues manifest as segmentation faults on Apple Silicon Macs with Clang 19.1.7.
It modifies
src/tools/CMakeLists.txtto compile correctly in Apple systems.