Calculator JSON load rewrite and fixes for several characters #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote how the calculator loads scripts so that we can use a .json file instead of having to dump all of it into a single line in hitboxDBJSON.js
I barely knew what I was doing with this. But I got it working at least with Live server extension in vs code. Hopefully it is a correct method of doing it.
Browser will complain about CORS if you just try to use the file system to load the website locally. So if that is a use case that needs to be supported, a different method that at least makes the JSON not all one line would be to use string template with `` characters to go across more lines. This would go back to not having a real .json file though.
The Link and Young Link clean rang hitboxes were removed as they don't seem to exist.
Added a fix for Zelda uthrow breaking and tossing an exception when used against Fox. I didn't really get exactly what was going on, but I just added another item to the throw data like the others but for the frame it was asking for and not finding.
Added some common charge levels for the Pikachu, Pichu, and Luigi sideb. Apparently they start at different charges based on if you activate in the first three frames of moving the stick or not (not exactly like other smash/tilt, but close enough to refer to it that way). They seem like they do continuous charging, I just didn't feel like putting every single percent in at the moment.