Open
Conversation
* Added support for timestamped logging with configuration (file, output level, rotation, etc) via command line arguments to avoid needing a configuration file * Added --dry-run option * Start/stop windows are now configurable and changed defaults * Do not re-stop an instance that has been started since the stop window began. This stops people from having to fight the script if they wanted to restart an instance that was shut down on them. * Iterate through all Elastic Load Balancers in the region and, if an instance being started was registered to one, pause, de-register it, then re-register it to make sure the instances come back online in the ELB. Otherwise, instances typically remained dead in ELBs despite being started back up. Bug fixes: * A run at the exact window time would fail to start or stop instances, thus making the windows required. It should now work with no window as long as the start/stop tags match up with cron intervals (e.g. on 5 minute boundaries) Code changes: * Separated, simplified, and clarified time to action logic * Added a simple unit test to confirm time to action logic functionality * Skip cn-north-1, us-gov-west-1 regions to avoid superfluous errors. This could be handled better, patches welcome. * Don't swallow potentially useful exceptions. These improvements graciously donated by TASER's Evidence.com team. Join us: https://www.evidence.com/careers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features:
Bug fixes:
Code changes:
These improvements graciously donated by TASER's Evidence.com team. Join us: https://www.evidence.com/careers