Function converts coin data into extensible time series format. Useful for extended time series analysis.#7
Conversation
…l for extended time series analysis. Function converts coin data into extensible time series format. Function is very simple but might be useful for others. Requires xts library.
schaer-unibas
left a comment
There was a problem hiding this comment.
Hi @swissecon-cryptecon
Thanks for the contribution! Much appreciated.
It looks like "price" is hardcoded in the function. An additional parameter, that allows you to choose between "price", "volume" and "market_cap", is required.
Furthermore it would be great to integrate the functionality in the basic getCoinData() function instead of a adding a new function for the conversion. There you already have the option between "json" and "csv", sou you could simply add the option for another "xts"paramer.
Last but not least we'd have to update the descriptions and dependencies.
Once again: Thank you very much! Would be much appreciated if you keep contributing. Once the mentioned issues are resolved I will gladly merge the PR.
|
Hi @Chainomics Thank you for your feedback. To integrate the xts conversion into to the function getCoinData() is a good idea. I will pull another request once I have incorporated your comments. However, I get into trouble when calling prepareCointData() without an argument (see "Issues"). Maybe I did not load the package correctly? Ps: Sorry for any inconvenience, this is my first contribution on GitHub. |
|
I am owner of xan187! I am worried about receiving my crypto.I do appreciate the help. But I've had no personal notice. And Mat will not answer any questions. Has caused a lot of problems at home. Please let me know where my crypto is going. 19012620034 cloud901memphis@gmail.com |
I am xan187 please contact me and let me know how to get my coins. I am not in control of the api and repos. They appear to me to be stolen. Cloud901memphis@gmail.com |
Function converts coin data into extensible time series format. Function is very simple but might be useful for others. Requires xts library.