Skip to content

Function converts coin data into extensible time series format. Useful for extended time series analysis.#7

Open
swissecon-cryptecon wants to merge 1 commit intoschaer-unibas:masterfrom
swissecon-cryptecon:patch-1
Open

Function converts coin data into extensible time series format. Useful for extended time series analysis.#7
swissecon-cryptecon wants to merge 1 commit intoschaer-unibas:masterfrom
swissecon-cryptecon:patch-1

Conversation

@swissecon-cryptecon
Copy link
Copy Markdown

Function converts coin data into extensible time series format. Function is very simple but might be useful for others. Requires xts library.

…l for extended time series analysis.

Function converts coin data into extensible time series format. Function is very simple but might be useful for others. Requires xts library.
Copy link
Copy Markdown
Owner

@schaer-unibas schaer-unibas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @swissecon-cryptecon
Thanks for the contribution! Much appreciated.

It looks like "price" is hardcoded in the function. An additional parameter, that allows you to choose between "price", "volume" and "market_cap", is required.

Furthermore it would be great to integrate the functionality in the basic getCoinData() function instead of a adding a new function for the conversion. There you already have the option between "json" and "csv", sou you could simply add the option for another "xts"paramer.

Last but not least we'd have to update the descriptions and dependencies.

Once again: Thank you very much! Would be much appreciated if you keep contributing. Once the mentioned issues are resolved I will gladly merge the PR.

@swissecon-cryptecon
Copy link
Copy Markdown
Author

Hi @Chainomics

Thank you for your feedback. To integrate the xts conversion into to the function getCoinData() is a good idea. I will pull another request once I have incorporated your comments. However, I get into trouble when calling prepareCointData() without an argument (see "Issues"). Maybe I did not load the package correctly?

Ps: Sorry for any inconvenience, this is my first contribution on GitHub.

@ghost
Copy link
Copy Markdown

ghost commented Nov 16, 2021

I am owner of xan187! I am worried about receiving my crypto.I do appreciate the help. But I've had no personal notice. And Mat will not answer any questions. Has caused a lot of problems at home. Please let me know where my crypto is going. 19012620034 cloud901memphis@gmail.com
I have seen them listed in Nfts on open sea and I'm also seeing Gemini and kraken and Rarible please help me understand

@ghost
Copy link
Copy Markdown

ghost commented Nov 23, 2021

Hi @swissecon-cryptecon

Thanks for the contribution! Much appreciated.

It looks like "price" is hardcoded in the function. An additional parameter, that allows you to choose between "price", "volume" and "market_cap", is required.

Furthermore it would be great to integrate the functionality in the basic getCoinData() function instead of a adding a new function for the conversion. There you already have the option between "json" and "csv", sou you could simply add the option for another "xts"paramer.

Last but not least we'd have to update the descriptions and dependencies.

Once again: Thank you very much! Would be much appreciated if you keep contributing. Once the mentioned issues are resolved I will gladly merge the PR.

I am xan187 please contact me and let me know how to get my coins. I am not in control of the api and repos. They appear to me to be stolen. Cloud901memphis@gmail.com
Cloud9memphis@yahoo.com 9012620034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants