Open
Conversation
- Tests do not pass yet because .clj, not .cljc
- All tests now pass, both CLJ and CLJS. - However, do check the (very few) things marked “FIXME” and address them as you see fit. They involve `eval` (CLJ only), a reflection test (CLJ only), a cljs.test multimethod which is only available from CLJ, and platform-specific stack traces in CLJS. None of these things alter the functionality of Slingshot.
- In order to do this, had to drop 1.4, 1.5, 1.6 support. We keep 1.7 and 1.8 support. .cljx is an option if we need to have 1.4-1.6 support still.
This fixes something that appeared when I tried to use the CLJS version of Slingshot in a project — namely, that slingshot.support referring to its own macro apparently sometimes causes a problem (though it doesn’t always). Thus, the offending macros have been moved to slingshot.util.
|
Hi @scgilardi, did you ever get a chance to look this over? Do you think it's a good idea? |
Author
(try+
(throw (ex-info "foobar" {}))
(catch js/Error e
(println "foobar caught")) ; <------------- is not printed |
Owner
|
Looks interesting! I'll go over it in more detail and write again. |
|
@scgilardi Much time has passed since then. Apparently we won't see this functionality anymore. |
|
Future work on this will happen here clj-commons#2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
them as you see fit. They involve
eval(CLJ only), a reflection test(CLJ only), a cljs.test multimethod which is only available from CLJ,
and platform-specific stack traces in CLJS. None of these things alter
the functionality of Slingshot.
To those who want this PR on clojars, it's available as
[alexandergunnarson/slingshot "0.14"].