Skip to content

Conversation

@matthiasL-scality
Copy link
Contributor

Purpose

Add search for image by name on scaleway marketplace (we can put UUID, scaleway image created with packer for example, or use the name/label from marketplace)

@matthiasL-scality matthiasL-scality requested a review from a team as a code owner January 26, 2026 10:01
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.20%. Comparing base (31e090c) to head (86e2b09).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
runner_manager/backend/scaleway.py 85.71% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
+ Coverage   85.15%   85.20%   +0.04%     
==========================================
  Files          36       36              
  Lines        1725     1764      +39     
==========================================
+ Hits         1469     1503      +34     
- Misses        256      261       +5     
Flag Coverage Δ
api 57.87% <2.38%> (-1.26%) ⬇️
unit 69.55% <85.71%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trunk-io
Copy link

trunk-io bot commented Jan 26, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Copy link

@cmeron cmeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific need for this ?

We had many issues with costly marketplace images on AWs with not so obvious hidden costs. I hope Scaleway have less dark patterns on this but lets double check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants