Skip to content

Conversation

@matthiasL-scality
Copy link
Contributor

Purpose

Add scaleway backend to runner-manager

@matthiasL-scality matthiasL-scality requested a review from a team as a code owner January 14, 2026 13:24
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 87.22222% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.15%. Comparing base (c28657f) to head (a33e363).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
runner_manager/backend/scaleway.py 85.53% 23 Missing ⚠️

❌ Your patch status has failed because the patch coverage (27.22%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
+ Coverage   84.91%   85.15%   +0.24%     
==========================================
  Files          35       36       +1     
  Lines        1545     1725     +180     
==========================================
+ Hits         1312     1469     +157     
- Misses        233      256      +23     
Flag Coverage Δ
api 59.13% <27.22%> (-3.72%) ⬇️
unit 69.15% <87.22%> (+2.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthiasL-scality matthiasL-scality force-pushed the PTFE-2629-add-scaleway-backend branch from 52a85ba to a33e363 Compare January 14, 2026 13:27
Copy link

@cmeron cmeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks clean !

Too bad it doesn't support Elastic Metal but as it's using a different API entrypoint, it's not that simple to add cleanly.
Let's add instances for now!

@matthiasL-scality matthiasL-scality merged commit 31e090c into main Jan 19, 2026
18 of 20 checks passed
@matthiasL-scality matthiasL-scality deleted the PTFE-2629-add-scaleway-backend branch January 19, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants