Update metaconfig, publish cli for Scala 3#563
Update metaconfig, publish cli for Scala 3#563keynmol wants to merge 5 commits intoscalameta:mainfrom
Conversation
keynmol
commented
Sep 27, 2021
- Normalise location of dependency versions
- Update metaconfig to 0.9.15 for all but Scala 2.11
- Re-enable CLI cross-publishing for Scala 3
| val ms = "2.1.1" | ||
| } | ||
|
|
||
| def pprint(scalaV: String) = |
There was a problem hiding this comment.
FYI these can also be defined as val pprint = Def.setting { if (scalaVersion.value) ... } and then used as pprint.value
|
@tgodzik I remember you mentioned something about scala 3 and pprint in mdoc.. I had to modify a few tests to make them work - not actually sure why, but can you confirm that what you were referring to was |
|
We don't use pprint for Scala 3, that's because we didn't want to wait for the new versions to be released (it's not a problem now) and also Martin was using worksheets for Moocs, which he preferred to have normal toString for. We could switch to pprint now, but it would probably be good to have a modifier for toString |
|
I think a modifier like That said, I can restore the old behaviour on Scala 3 - I'm just not sure how pprint was excluded before. I think Scala 2 and Scala 3 share the ReplVariablePrinter? |
|
It was a separate implementation classes called Printing in: https://github.com/scalameta/mdoc/blob/main/runtime/src/main/scala-3/mdoc/internal/document/Printing.scala If I understand correctly what you are asking about 🤔 |
@keynmol there is a |