Skip to content

PWA with Serwist #40

Open
portdeveloper wants to merge 6 commits intopwafrom
pwa-init
Open

PWA with Serwist #40
portdeveloper wants to merge 6 commits intopwafrom
pwa-init

Conversation

@portdeveloper
Copy link
Member

This extension uses https://serwist.pages.dev/ to add PWA functionalities to SE-2.

The current problems are:

  • I couldn't understand how to use the .gitignore template.
  • nextconfig template needs to be updated because we need to add things outside of the what the current template offers.
  • Need to do more tests with everything

@portdeveloper portdeveloper changed the base branch from main to pwa November 30, 2024 20:17
@carletex carletex requested a review from damianmarti December 2, 2024 11:27
@@ -0,0 +1,37 @@
// This does not work with the current template
// because we also need to add things one level up of the what
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you need outside nextjs?

Copy link
Member Author

@portdeveloper portdeveloper Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t use withSerwist function with the current templating method as it only lets us add things inside the next config.
- What withSerwist does: https://github.com/serwist/serwist/blob/main/packages/next/src/index.ts
- How to use withSerwist for nextjs: https://serwist.pages.dev/docs/next/getting-started
- Our current template: scaffold-eth/create-eth@e950e6f#diff-f224a81f9a3dbaf31c32522a71b1d6c83a3697cea55ed44920553d6d0653e9a2R5
- We need to able to add something in the next config file, but not inside the next config, as shown above in the Serwist link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aja, I understand. I will think about a way to do it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants