Login with MitID token (kodeviser) #292
Open
+780
−485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @jballe . Thank you for your contribution. I am testing out your fork in my own env now. |
Owner
|
This is an issue - I cannot submit the form with specifying a token+pas. And I have not selected "mitid_use_token": Can we also add some descriptive text, so it is totally clear, that this token+password is for "kodeviser"? Remember everything has en english translation as well. Btw, why use this "kodeviser"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #290
This is my first contribution. When I just open the devcontainer and save, there are some formatting changes that differ from what was already there, so there are more changes shown. Let me knowe if I should do anything different.
This change just adds token and password to the initial configuration dialog but shouldn't save those to the database. I am myself confident with this as the token has a very short timespan. Maybe a better solution was to add it to the website where you also choose identities.