Conversation
Contributor
|
Updated repo README file. |
Contributor
|
Repo README file is up to date. Nothing to commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #4 a few tests failed on ubuntu-devel. I updated these tests so they are more robust to numerical drift.
I also added tests regarding parallelisation. These tests will be skipped on CRAN for simplicity, but they will be included in checks.
covr::package_coverage()runs as CRAN by default, so I modified README.Rmd to tell covr to include these tests when calculating coverage.Plotting functions seem difficult to test on CI. I kept
vdiffrtests so these are tested locally, but for the CI and specifically for covr I added a hack in which I am only testing that the returned objects are ggplot objects.. Since I always run tests locally before opening a PR, I feel that this hack is acceptable.