adds partner organizations to map and list#99
Conversation
for more information, see https://pre-commit.ci
✅ Deploy Preview for sbs-austria ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
src/routes/+layout.ts
Outdated
| const footer = await fetch_yaml(`Footer`) | ||
| const social = await fetch_yaml(`Social`) | ||
| const chapters = await fetch_chapters() | ||
| var chapters = await fetch_chapters() |
There was a problem hiding this comment.
Don't use var. Prefer let or const.
src/lib/ChapterMap.svelte
Outdated
| `chapter`, | ||
| chap.acceptsSignups ? `active` : chap.partnerAssociation ? 'partner' : `starting`, | ||
| ], |
There was a problem hiding this comment.
Similar suggestion to #98, how about instead of defining a bunch of booleans, we add an attribute status: 'active' | 'starting' | 'partner' or similar to the Chapter type?
There was a problem hiding this comment.
But we keep the bunch of booleans in Contentful right? There is no nice way to implement that you can select from a set of possible states.
There was a problem hiding this comment.
acceptSignups is the boolean variable that is currently directly loaded from Contentful. Maybe we should add an additional state for the signupsState?
There was a problem hiding this comment.
There is no nice way to implement that you can select from a set of possible states.
Yes there is. I just added a "state" to chapters. Take a look on Contentful for how to set that up.
There was a problem hiding this comment.
I second this, this would be more elegant and easier to modify in the future.
dominikgeissler
left a comment
dominikgeissler
left a comment
There was a problem hiding this comment.
LGTM, but I think the points @janosh mentioned (esp. with the contentful-interaction) would be much more elegant
kleinicke
force-pushed
the
feature/external_orgs
branch
2 times, most recently
from
58d92b6 to
29af134
Compare
|
Ok, I changed everything which was in question. So now we can merge it. |
3 participants
Can be merged, if you think it's fine.
We could discuss about the color for partner organisations on the map.