Conversation
✅ Deploy Preview for sbsev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
for more information, see https://pre-commit.ci
✅ Deploy Preview for sbs-austria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for sbs-austria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| // Map status to CSS class for map markers | ||
| function getMapClass(status: ChapterStatus): string { | ||
| if (status === 'acceptStudents' || status === 'acceptPupils' || status === 'active') { | ||
| return 'active' |
There was a problem hiding this comment.
I think there are also chapters who are starting but also accept signups right? Why dont we just do
return statusor remove this function?
There was a problem hiding this comment.
If they already accept signups, they are kind of active I would say. Starting would only for new chapters where you don't have anyone yet checking the local email addresses and allowing no signups. Once you want to allow signups you could just move the status to active. In that case you will also need to check the local email addresses (or just create forwards to your email address).
| const openChapters = $derived(Array.isArray(chapters) ? chapters.filter((ch) => ch.acceptsSignups) : []) | ||
| const startingChapters = $derived(Array.isArray(chapters) ? chapters.filter((ch) => ch.status == `starting`) : []) | ||
| const partnerChapters = $derived(Array.isArray(chapters) ? chapters.filter((ch) => ch.status == `partner`) : []) | ||
| const openChapters = $derived(Array.isArray(chapters) ? chapters.filter((ch) => showsSignupSection(ch.status)) : []) |
There was a problem hiding this comment.
Nitpick: openChapters seems a bit misleading, maybe just use acceptsSignup? Is it a problem that openChapters and the other arrays are not disjoint?
| } | ||
|
|
||
| // Unified status values combining chapter maturity and signup availability | ||
| export type ChapterStatus = |
There was a problem hiding this comment.
We could use something like:
export type ChapterStatus =
'starting'
| 'active'
| 'partner'
export SignupStatus =
'all'
| 'noStudents'
| 'noPupils'
| 'none'for further flexibility. Or is this overkill?
| </a> | ||
| {:else} | ||
| <button class="btn blue disabled" disabled> | ||
| <IconGraduation {style} />{$microcopy?.location?.studentWaitlistFull ?? 'Warteliste voll'} |
There was a problem hiding this comment.
I would move the Warteliste voll to microcopy
| - Bericht in Zeitung/Internet | ||
| - Auflistung in Ehrenamtsregister | ||
| - Kooperationsparter | ||
| - Coronaschool |
There was a problem hiding this comment.
Why are these options removed? I think Philipp explicitly requested them
There was a problem hiding this comment.
really? He explicitly wanted to have local German organizations in the Werbemaßnamen list for Austria?
2 participants
Fixes #156
We can use a single single select button for selecting the status of the chapter on the website. Currently we have several boolean options to activate the signup buttons. But single select status allows to select the status of the chapter and also allows to disable signups for pupils or students individually.
The stati are:
active
starting
partner
acceptStudents
acceptPupils