Skip to content

Simplify signup values#164

Open
kleinicke wants to merge 5 commits intomainfrom
dev/simplify_signup_values
Open

Simplify signup values#164
kleinicke wants to merge 5 commits intomainfrom
dev/simplify_signup_values

Conversation

@kleinicke
Copy link
Member

@kleinicke kleinicke commented Jan 4, 2026

Remove non required default values
Move settings to the yml files

@netlify
Copy link

netlify bot commented Jan 4, 2026 •
edited
Loading

✅ Deploy Preview for sbs-austria ready!

Name Link
🔨 Latest commit 7bcbdf2
🔍 Latest deploy log https://app.netlify.com/projects/sbs-austria/deploys/6959d54475adf300080da176
😎 Deploy Preview https://deploy-preview-164--sbs-austria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 4, 2026 •
edited
Loading

✅ Deploy Preview for sbsev ready!

Name Link
🔨 Latest commit 7bcbdf2
🔍 Latest deploy log https://app.netlify.com/projects/sbsev/deploys/6959d544efa66c000851f372
😎 Deploy Preview https://deploy-preview-164--sbsev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 4, 2026 •
edited
Loading

✅ Deploy Preview for sbs-austria ready!

Name Link
🔨 Latest commit 8ccf6ca
🔍 Latest deploy log https://app.netlify.com/projects/sbs-austria/deploys/695ae9cadc2d3a0008489d15
😎 Deploy Preview https://deploy-preview-164--sbs-austria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 4, 2026 •
edited
Loading

✅ Deploy Preview for sbsev ready!

Name Link
🔨 Latest commit 8ccf6ca
🔍 Latest deploy log https://app.netlify.com/projects/sbsev/deploys/695ae9ca20f4f30008c49976
😎 Deploy Preview https://deploy-preview-164--sbsev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

dominikgeissler
dominikgeissler approved these changes Jan 4, 2026
View reviewed changes
src/routes/signup-student/+page.server.ts

// Load locale-specific YAML data
const messagesData = getLocaleModule(localeModules.messages, locale) || {
submitSuccess: { title: `🎉 ⭐ 🎉`, note: `Success!` },
Copy link
Contributor

@dominikgeissler dominikgeissler Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arent those supposed to be default values if the locale somehow fails?

Copy link
Member Author

@kleinicke kleinicke Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but I think if it fails it should really fail and not silently disappear, or what do you think?
There are a lot of fall back options inside and I'm not entirely sure if this a good thing.
Maybe I could add a test, making sure all locales are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominikgeissler dominikgeissler dominikgeissler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kleinicke @dominikgeissler