Add first occurrence highlighting to location dropdown#142
Open
chris234567 wants to merge 1 commit intosbsev:mainfrom
Open
Add first occurrence highlighting to location dropdown#142chris234567 wants to merge 1 commit intosbsev:mainfrom
chris234567 wants to merge 1 commit intosbsev:mainfrom
Conversation
✅ Deploy Preview for sbsev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for sbs-austria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
I like it, but maybe its a bit too much? Maybe try something like a lighter shade of the blue we use? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #58. This PR introduces highlighting of the first occurrence of each alphabetical character in the locations ("Standorte") list. The purpose is to make it easier for users to quickly discover cities in a long list.
We might consider an alternative approach: grouping locations by alphabetical headers (A, B, C…) instead of inline highlighting.
Please comment what you think.