Fix low-contrast issue for partner SVG logos in dark theme#141
Open
chris234567 wants to merge 1 commit intosbsev:mainfrom
Open
Fix low-contrast issue for partner SVG logos in dark theme#141chris234567 wants to merge 1 commit intosbsev:mainfrom
chris234567 wants to merge 1 commit intosbsev:mainfrom
Conversation
✅ Deploy Preview for sbsev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for sbs-austria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Issue #138 about the low contrast of the partners section on the main page where SVG icons were difficult to see against the dark theme background. The solution applies a 1pt drop shadow in white for every direction to the .svg. This increases contrast without altering the logo colors themselves, ensuring better accessibility and readability in dark mode.
However, the implementation via CSS selectors is not robust or clean. It would be much nice to do it via contentful (But I don't have access to the system, therefore this PR is serving just as a suggestion)
Changelog
Added
-a-href-mitmachen-kooperationspartner-wir-werden-unterstützt-durch-a-Additional information