Skip to content

feat(plasma-temple): product - export by platforms #1185

Open
kvpolyanskiy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(plasma-temple): product - export by platforms #1185

kvpolyanskiy wants to merge 1 commit into from

Conversation

@kvpolyanskiy
Copy link
Contributor

@kvpolyanskiy kvpolyanskiy commented Apr 11, 2022 •
edited by SberDevices-Eva
Loading

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @sberdevices/plasma-temple@1.59.0-canary.1185.51d9cf4becece69a2a12508948bcb5535704d508.0
# or 
yarn add @sberdevices/plasma-temple@1.59.0-canary.1185.51d9cf4becece69a2a12508948bcb5535704d508.0

@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 11, 2022

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1185/

@codecov
Copy link

codecov bot commented Apr 11, 2022 •
edited
Loading

Codecov Report

Merging #1185 (4627bf8) into master (11eb16a) will decrease coverage by 0.05%.
The diff coverage is 90.76%.

❗ Current head 4627bf8 differs from pull request most recent head 00d2046. Consider uploading reports for the commit 00d2046 to get more accurate results

@@            Coverage Diff             @@
##           master    #1185      +/-   ##
==========================================
- Coverage   88.88%   88.83%   -0.06%     
==========================================
  Files         453      451       -2     
  Lines        6219     6207      -12     
  Branches     1795     1795              
==========================================
- Hits         5528     5514      -14     
- Misses        690      692       +2     
  Partials        1        1
Flag Coverage Δ
plasma-b2c 95.84% <ø> (ø)
plasma-core 94.36% <ø> (ø)
plasma-temple 81.93% <90.76%> (-0.16%) ⬇️
plasma-ui 94.55% <ø> (ø)
plasma-web 92.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/components/Cart/CartOrder/CartOrder@mobile.tsx 83.33% <ø> (ø)
...andableProductDetails/ExpandableProductDetails.tsx 50.00% <50.00%> (-50.00%) ⬇️
...src/components/Product/ProductInfo/ProductInfo.tsx 50.00% <50.00%> (-50.00%) ⬇️
.../plasma-temple/src/components/Cart/Cart@common.tsx 88.46% <88.46%> (ø)
...c/components/Product/ProductPrice/ProductPrice.tsx 88.88% <88.88%> (-11.12%) ⬇️
...ackages/plasma-temple/src/components/Cart/Cart.tsx 100.00% <100.00%> (+11.53%) ⬆️
.../plasma-temple/src/components/Cart/Cart@mobile.tsx 100.00% <100.00%> (ø)
...plasma-temple/src/components/Cart/Cart@sberbox.tsx 100.00% <100.00%> (ø)
...sma-temple/src/components/Cart/Cart@sberportal.tsx 100.00% <100.00%> (ø)
...omponents/Cart/CartItemCaption/CartItemCaption.tsx 56.25% <100.00%> (-2.58%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cae723...00d2046. Read the comment docs.

@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 11, 2022

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1185/
ui storybook: http://plasma.sberdevices.ru/pr-1185/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1185/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1185/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1185/temple-storybook/

@kvpolyanskiy kvpolyanskiy force-pushed the feat.product-exports-by-platform branch from 7818e1d to 19ee15f Compare April 11, 2022 08:04
@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 11, 2022

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1185/

@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 11, 2022

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1185/
ui storybook: http://plasma.sberdevices.ru/pr-1185/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1185/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1185/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1185/temple-storybook/

@kvpolyanskiy kvpolyanskiy force-pushed the feat.product-exports-by-platform branch from 19ee15f to 6ca1605 Compare April 11, 2022 09:08
@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 11, 2022

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1185/

@kvpolyanskiy kvpolyanskiy force-pushed the feat.product-exports-by-platform branch from 6ca1605 to 22a48bc Compare April 11, 2022 09:31
@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 11, 2022

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1185/
ui storybook: http://plasma.sberdevices.ru/pr-1185/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1185/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1185/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1185/temple-storybook/

@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 11, 2022

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1185/

@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 11, 2022

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1185/
ui storybook: http://plasma.sberdevices.ru/pr-1185/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1185/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1185/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1185/temple-storybook/

@kvpolyanskiy kvpolyanskiy force-pushed the feat.product-exports-by-platform branch from 22a48bc to 486bdd1 Compare April 11, 2022 11:09
@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 11, 2022

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1185/

@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 11, 2022

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1185/
ui storybook: http://plasma.sberdevices.ru/pr-1185/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1185/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1185/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1185/temple-storybook/

@kvpolyanskiy kvpolyanskiy force-pushed the feat.product-exports-by-platform branch from 486bdd1 to 354615f Compare April 11, 2022 12:52
@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 11, 2022

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1185/

@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 11, 2022

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1185/
ui storybook: http://plasma.sberdevices.ru/pr-1185/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1185/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1185/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1185/temple-storybook/

@kvpolyanskiy kvpolyanskiy marked this pull request as ready for review April 11, 2022 13:40
@kvpolyanskiy kvpolyanskiy force-pushed the feat.product-exports-by-platform branch from 354615f to 4627bf8 Compare April 12, 2022 13:37
@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 12, 2022

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1185/

@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 12, 2022

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1185/
ui storybook: http://plasma.sberdevices.ru/pr-1185/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1185/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1185/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1185/temple-storybook/

@kvpolyanskiy kvpolyanskiy force-pushed the feat.product-exports-by-platform branch from 4627bf8 to 00d2046 Compare April 12, 2022 17:35
@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 12, 2022

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1185/

@SberDevices-Eva
Copy link
Collaborator

SberDevices-Eva commented Apr 12, 2022

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1185/
ui storybook: http://plasma.sberdevices.ru/pr-1185/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1185/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1185/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1185/temple-storybook/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@VladislavPetyukevich VladislavPetyukevich Awaiting requested review from VladislavPetyukevich

1 more reviewer

@LamaEats LamaEats LamaEats approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kvpolyanskiy @SberDevices-Eva @LamaEats