Merged
Conversation
alanlujan91
commented
Feb 1, 2023
Comment on lines
+257
to
+259
| parameters = agent.parameters.copy() | ||
| parameters["Rfree"] = parameters["Rfree"][0] | ||
| ind_shock_double = cism.IndShockConsumerType(**parameters) |
Collaborator
Author
There was a problem hiding this comment.
Not a HARK bug per se, but perhaps a design flaw...
Rfree is initially a float, but because of recent changes to HARK, it gets casted as a list, and a 1 element list in the case of infinite horizon. Then, when it is copied over, it is passed to this second agent as a list, which it does not like, so it has to be recast as a float again.
Collaborator
Author
There was a problem hiding this comment.
Although maybe this case should be handled by HARK anyway.
Owner
|
This is ready to merge now, right? |
Collaborator
Author
|
Yes, but still does not fix #193 |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge.
Closes #186 when tests pass.
To see error, try running python simulate/run_any_simulation.py output/20230127_ls