Conversation
2 tasks
86c58b4 to
7453aae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 요약
대화 활성 여부가 항상 false 처리되고 대화 중에도 SSE 알림이 전송되어 이를 수정
체크리스트
상세 설명
DirectMessageEventListener.extraUserId()에서MoplUserDetails로만 처리하여 userId가 null로만 들어옴isSubscribed()가 항상 false가 되어 이벤트 생성 및 알림 전송이 되어 미확인 알림 카운트 증가/DB 알림 삭제가 이뤄지고, 알림 배지 클릭 시 정합성이 맞춰지면서 다시 카운트가 감소하는 현상이 존재변경된 파일
ReviewServiceDirectMessageSubscriptionRegistryDirectMessageEventListener추가된 파일
DirectMessageReadService제거된 파일
검증 단계
추가 코멘트