Open
Conversation
sawantpritam
requested changes
Dec 23, 2021
Owner
sawantpritam
left a comment
sawantpritam
left a comment
There was a problem hiding this comment.
@Ragini2 Please work on review comments.
|
|
||
| @CLDPGSQL @TC-Invalid-TestData-for-ReferenceName&ConnectionName | ||
| @cloudSQLPostgreSQL | ||
| Scenario: User is able to Open and enter invalid test data for Reference Name & Connection Name |
Owner
There was a problem hiding this comment.
What are you validating in this scenarios ?
| @@ -38,7 +38,3 @@ Feature: CloudSQLPostGreSQL Sink Design Time | |||
| Then Verify Connection Name with private instance type | |||
Owner
There was a problem hiding this comment.
are you validating any error message ?
| Then Enter Table Name "cloudPsqlTableName" and Connection Name | ||
| Then Validate Connector properties | ||
| Then Enter Driver Name with Invalid value | ||
| Then Verify Driver Name field with Invalid value entered |
Owner
There was a problem hiding this comment.
Verify driver name field error for invalid value
| @@ -15,23 +15,23 @@ Feature: CloudSQLPostGreSQL Source Design Time | |||
| | importQuery | | |||
Owner
There was a problem hiding this comment.
alignment of | is not proper
| Then Enter Connection Name and Import Query "cloudPsqlImportQuery" | ||
| Then Validate Connector properties | ||
| Then Enter Driver Name with Invalid value | ||
| Then Verify Driver Name field with Invalid value entered |
Owner
There was a problem hiding this comment.
Same comment as Sink validation
| } | ||
|
|
||
| @Then("Capture output schema") | ||
| public void captureOutputSchema() { |
Owner
There was a problem hiding this comment.
Schema validation needs to be changed
| Then Preview and run the pipeline | ||
| Then Verify the preview of pipeline is "success" | ||
| Then Click on PreviewData for cloudSQLPostgreSQL | ||
| Then Verify Preview output schema is not null |
Owner
There was a problem hiding this comment.
Schema validation needs to be changed
| } | ||
|
|
||
| @Then("Verify Preview output schema is not null") | ||
| public void verifyPreviewOutputSchemaIsNotNull() { |
Owner
There was a problem hiding this comment.
Schema validation needs to be changed
| CdfCloudSqlPostGreSqlActions.enterDatabaseName(CdapUtils.pluginProp("pSqlDatabaseName")); | ||
| CdfCloudSqlPostGreSqlActions.enterConnectionName(CdapUtils.pluginProp("pSqlConnectionNameInvalid")); | ||
| CdfCloudSqlPostGreSqlActions.enterTableName(CdapUtils.pluginProp("pSqlTableNameCS")); | ||
| CdfCloudSqlPostGreSqlActions.enterReferenceName(CdapUtils.pluginProp("cloudPsqlReferenceNameInvalid")); |
| ERROR_MESSAGE_SPLIT_COLUMN_NAME=Split-By Field Name must be specified if Number of Splits is not set to 1. | ||
| ERROR_MESSAGE_NUMBER_OF_SPLITS_NAME=Invalid value for numSplits '0'. Must be at least 1. | ||
| ERROR_MESSAGE_NUMBER_OF_BOUNDING_QUERY=Bounding Query must be specified if Number of Splits is not set to 1. No newline at end of file | ||
| ERROR_MESSAGE_NUMBER_OF_BOUNDING_QUERY=Bounding Query must be specified if Number of Splits is not set to 1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pr for ClouSqldPsql