Updated : by harshit-google · Pull Request #22 · sawantpritam/google-cloud

harshit-google · 2022-03-24T09:11:26Z

Sap slt plugins e2e selenium integration test.
This PR includes

Design time test scenarios
Negative test scenarios
Runtime Integration test scenarios

SLTActions.java SLTLocators.java StepDefinitionSLT.java

sawantpritam · 2022-03-24T09:29:23Z

e2e-test/java/io/cdap/plugin/slt/utils/CDAPUtils.java

@@ -0,0 +1,59 @@
+/*


Delete this file. Use PluginPropertyUtils.java from e2e frameweork

File removed

sawantpritam · 2022-03-24T09:29:47Z

e2e-test/resources/error_message.properties

+invalidClient=CDF_SAP_01404 - SAP connection test failed. Please verify the connection parameters. Root Cause: JCO_ERROR_CONFIGURATION - Parameter SAP client ('jco.client.client') needs to be a three digit number string instead of 'abc'
+invalidLang=CDF_SAP_01404 - SAP connection test failed. Please verify the connection parameters. Root Cause: JCO_ERROR_CONFIGURATION - Parameter logon language ('jco.client.lang') code 'invalid' is invalid
+invalidCred=CDF_SAP_01404 - SAP connection test failed. Please verify the connection parameters. Root Cause: JCO_ERROR_LOGON_FAILURE - Name or password is incorrect (repeat logon)
+


remove extra empty line

sawantpritam · 2022-03-24T09:29:53Z

e2e-test/resources/PluginParameters.properties

+bqProjectId=cdf-athena
+dataset=sap_automation
+IM_GCP_KEY_NAME=CDFSLT
+


remove extra empty lines

Done in last commit.

sawantpritam · 2022-03-24T09:30:36Z

e2e-test/java/io/cdap/plugin/slt/utils/package-info.java

@@ -0,0 +1,19 @@
+/*
+ * Copyright © 2021 Cask Data, Inc.


Change year to 2022

Check in all licences.

sawantpritam · 2022-03-24T09:36:01Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+    public static SLTLocators sltLocators = new SLTLocators();
+    public static String rawLog = null;
+    private static WebDriver CDFDriver;
+    BigQueryClient bqClient = new BigQueryClient();


Remove this Instantiation.

sawantpritam · 2022-03-24T10:51:05Z

e2e-test/java/io/cdap/plugin/slt/actions/SLTActions.java

+        elementHelper.sendKeys(sltLocators.jcoclientuser, CDAPUtils.getPluginProp(jcoclientuser));
+        elementHelper.sendKeys(sltLocators.jcoclientpasswd, CDAPUtils.getPluginProp(jcoclientpasswd));
+    }
+    public void sltplugin_click() {


Use generic plugin click action from CdfStudioActions

Method updated.

sawantpritam · 2022-03-24T10:52:38Z

e2e-test/java/io/cdap/plugin/slt/actions/SLTActions.java

+        elementHelper.clickOnElement(sltLocators.sltplugin);
+    }
+
+    public String rowError_color() {


rowError_color -> getRowErrorBorderColor

getRowErrorBorderColor used.

sawantpritam · 2022-03-24T10:53:00Z

e2e-test/java/io/cdap/plugin/slt/actions/SLTActions.java

+        return elementHelper.getElementCssProperty(SLTLocators.rowError, "border-color");
+    }
+
+    public void next_click() {


clickNextButton

Updated as per method action.

sawantpritam · 2022-03-24T10:53:38Z

e2e-test/java/io/cdap/plugin/slt/actions/SLTActions.java

+        elementHelper.clickOnElement(sltLocators.table(tableName));
+    }
+
+    public void datasetName_fill (String stagingBucket) {


enterDatasetName

Updated as per method action.

sawantpritam · 2022-03-24T10:55:43Z

e2e-test/java/io/cdap/plugin/slt/actions/SLTActions.java

+        elementHelper.clickOnElement(sltLocators.deployPipeline);
+    }
+
+    public void startPipeline() {


clickStartPipelineButton

Check all method names. Should start with action(i.e click , enter , select, get etc)

Updated as per method action.

sawantpritam · 2022-03-24T10:57:57Z

Please add proper PR title.

sawantpritam · 2022-03-24T10:58:14Z

Indent looks incorrect. Please reformat all files in the PR using this settings file - https://cdap.atlassian.net/wiki/spaces/CE/pages/1594098619/Coding+Standard

sawantpritam · 2022-03-24T11:46:52Z

e2e-test/java/io/cdap/plugin/slt/actions/SLTActions.java

+
+    static {
+        CDFDriver = SeleniumDriver.getDriver();
+        sltLocators = SeleniumHelper.getPropertiesLocators(SLTLocators.class);


assignment to sltLocators is not required. You can use directly with classname
i.e. likeSLTLocators.name SLTLocators.gcsDataPath

sawantpritam · 2022-03-24T11:48:03Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.util.*;


avoid use of * in imports

sawantpritam · 2022-03-24T11:49:31Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+    private static String guid = null;
+    static boolean errorExist = false;
+    static String color;
+    private static AssertionHelper assertionHelper = new AssertionHelper();


Remove instantiation. Use directly with className (AssertionHelper, ElementHelper, WaitHelper)

sawantpritam · 2022-03-24T11:56:26Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+        sapRecordsCount = 0;
+    }
+
+    @When("^Source is SAP SLT fill connection parameters$")


Separate steps
1.Select source plugin
2.Configure plugin with required properties

sawantpritam · 2022-03-24T12:00:29Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+        sltActions.next_click();
+    }
+
+    @Then("^Select Table \"([^\"]*)\"$")


Why are u using regular expressions.
You can simplify it like - > @then("Select Table {string}")

Applies to all

sawantpritam · 2022-03-24T12:09:48Z

e2e-test/features/DesignTimeSLT.feature

+    Then Click on next
+    Then Click on next
+    Then Click on Deploy Replication Pipeline
+    Then Update mass transfer id table: "<table>" job mode to "stop_load"


Add validation

Working in progress.

sawantpritam · 2022-03-24T12:10:23Z

e2e-test/features/DesignTimeSLT.feature

+Feature: Design Time SLT Scenario
+
+  @SLT @Design-Time @Sanity
+  Scenario Outline: User is able to provides input to SLT parameters


->Verify user is able to provides input to SLT parameters

Similar comment for all scenario descriptions

Working in progress.

sawantpritam · 2022-03-24T12:11:44Z

e2e-test/features/DesignTimeSLTError.feature

+      When User crates new MTID on "Automation" SAP
+      When User updates mtid config in CDF_R_SLT_SETTINGS program
+      When Source is SAP SLT fill connection parameters
+      Then User is able to set SLT parameter <option> as <input> and getting row <errorMessage> for wrong input


-> Verify user is able...............

Working in progress.

sawantpritam · 2022-03-24T12:12:13Z

e2e-test/features/RunTimeSLT.feature

+  @SLT @Run-Time @Sanity
+  Scenario: User is able to create MTID and update CDF_R_SLT_SETTINGS program
+    Given User crates new MTID on "Automation" SAP
+    When User updates mtid config in CDF_R_SLT_SETTINGS program


Add validation step

Working in progress.

sawantpritam · 2022-03-24T12:13:01Z

e2e-test/features/RunTimeSLT.feature

+    Then Wait till SLT pipeline is in running state and no error occurs
+    Then Close logs and stop the pipeline
+    Then Get Count of no of records transferred from SLT to BigQuery in "<table>"
+    Then User is able to validate record count in BQ matches with count in SAP


->Validate record count in BQ matches with count in SAP

Working in progress.

harshit-google

Pushed the code all the comments except updates required in Feature file. Will push those changes tomorrow.

harshit-google · 2022-03-28T13:03:18Z

e2e-test/features/DesignTimeSLT.feature

+Feature: Design Time SLT Scenario
+
+  @SLT @Design-Time @Sanity
+  Scenario Outline: User is able to provides input to SLT parameters


Working in progress.

harshit-google · 2022-03-28T13:31:56Z

e2e-test/features/DesignTimeSLT.feature

+  Scenario: User is able to set Replicate Existing Data as false
+    Given Open CDF replication and initiate pipeline creation
+    When Source is SAP SLT
+    Then Replicate Existing Data is set to false


Working in progress.

harshit-google · 2022-03-28T13:32:03Z

e2e-test/features/DesignTimeSLT.feature

+    Then Click on next
+    Then Click on next
+    Then Click on Deploy Replication Pipeline
+    Then Update mass transfer id table: "<table>" job mode to "stop_load"


Working in progress.

harshit-google · 2022-03-28T13:32:11Z

e2e-test/features/DesignTimeSLTError.feature

+      When User crates new MTID on "Automation" SAP
+      When User updates mtid config in CDF_R_SLT_SETTINGS program
+      When Source is SAP SLT fill connection parameters
+      Then User is able to set SLT parameter <option> as <input> and getting row <errorMessage> for wrong input


Working in progress.

harshit-google · 2022-03-28T13:32:18Z

e2e-test/features/RunTimeSLT.feature

+  @SLT @Run-Time @Sanity
+  Scenario: User is able to create MTID and update CDF_R_SLT_SETTINGS program
+    Given User crates new MTID on "Automation" SAP
+    When User updates mtid config in CDF_R_SLT_SETTINGS program


Working in progress.

harshit-google · 2022-03-28T13:35:21Z

e2e-test/java/io/cdap/plugin/slt/locators/SLTLocators.java

+        CDFDriver = SeleniumDriver.getDriver();
+    }
+
+    @FindBy(how = How.XPATH, using = "//input[@data-cy=\"name\"]")


Using ' for all the locators

harshit-google · 2022-03-28T13:35:32Z

e2e-test/java/io/cdap/plugin/slt/locators/SLTLocators.java

+    @FindBy(how = How.XPATH, using = "//input[@data-cy=\"name\"]")
+    public static WebElement name;
+    @FindBy(how = How.XPATH, using = "//input[@data-cy=\"gcpProjectId\"]")
+    public static WebElement gcpProjectId;


Empty lines added.

harshit-google · 2022-03-28T13:36:42Z

e2e-test/java/io/cdap/plugin/slt/locators/SLTLocators.java

+    @FindBy(how = How.XPATH, using = "//input[@data-cy=\"gcpProjectId\"]")
+    public static WebElement gcpProjectId;
+    @FindBy(how = How.XPATH, using = "//div[contains(text(),'SAP Landscape Transformation (SLT)')]")
+    public static WebElement sltplugin;


As Replicator UI is quite different than Batch source cant use any of the existing Methods available in e2e.

harshit-google · 2022-03-28T13:36:53Z

e2e-test/java/io/cdap/plugin/slt/locators/SLTLocators.java

+    @FindBy(how = How.XPATH, using = "//input[@data-cy=\"sapJcoLibGcsPath\"]")
+    public static WebElement sapJcoLibGcsPath;
+    @FindBy(how = How.XPATH, using = "//input[@data-cy=\"jco.client.ashost\"]")
+    public static WebElement jcoclienthost;


harshit-google · 2022-03-28T13:38:07Z

e2e-test/java/io/cdap/plugin/slt/locators/SLTLocators.java

+    public static WebElement viewsummary;
+    @FindBy(how = How.XPATH, using = "//span[contains(text(),'Deploy Replication Job')]")
+    public static WebElement deployPipeline;
+    @FindBy(how = How.XPATH, using = "//*[contains(text(), 'Logs')]")


Tried to use data-cy tag as much possible for uniformity but for the tags I have used best possible option available.

poojantcs · 2022-03-28T13:56:31Z

e2e-test/features/RunTimeSLT.feature

+    Then Enter the BigQuery Properties for slt datasource
+    Then Click on next
+    Then Click on next
+    Then Click on next


We have three steps clicking on the Next button. I believe, they are clicking the Next button element on three different pages. It will make test more readable if the step can be enhanced to take the page name and print it in the logs.

Then Click on next button on "String"

poojantcs · 2022-03-28T13:59:12Z

e2e-test/java/io/cdap/plugin/slt/locators/SLTLocators.java

+
+    public static By replicationStatus = By.xpath("//*[contains(text(),'replication status: Process: ')]");
+
+    public static WebElement table (String tableName) {


Update the locator name: locateTable(String tableName).

Use the same naming convention for all the methods in PO class: locateXYZ()

sawantpritam · 2022-03-30T12:52:39Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+    }
+  }
+
+  @Then("{string} the {string} records with {string} in the sap table")


@then("CUD action {string} the count {string} records with mode {string} in the sap table")

sawantpritam · 2022-03-30T12:54:04Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+  }
+
+  @Then("{string} the {string} records with {string} in the sap table")
+  public void createTheRecordsInTheSLTDatasourceFromJCO(String process, String recordcount, String rfcName)


->performCUDOperationInTheSLTDatasourceFromJCO

sawantpritam · 2022-03-30T12:54:39Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+  }
+
+  @Then("{string} the {string} records with {string} in the sap table")
+  public void createTheRecordsInTheSLTDatasourceFromJCO(String process, String recordcount, String rfcName)


recordcount -> recordsCount

sawantpritam · 2022-03-30T12:56:39Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+  @Given("^Open CDF replication and initiate pipeline creation")
+  public void open_cdf_replication() throws IOException, InterruptedException {
+    openCdf();
+    SeleniumDriver.getDriver().get("http://localhost:11011/cdap/ns/default/replication/create");


pass url as parameter from properties file

sawantpritam · 2022-03-30T12:59:53Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+  }
+
+
+  @Given("^Open CDF replication and initiate pipeline creation")


check and remove regex from all stepDefinitions

sawantpritam · 2022-03-30T13:19:08Z

e2e-test/java/io/cdap/plugin/slt/locators/SLTLocators.java

+    }
+
+    public static WebElement inputParameter(String inputParameter) {
+        return SeleniumDriver.getDriver().findElement(By.xpath("//*[@data-cy='" +


xpath can be simplified -> //input[@data-cy='" + inputParameter + "']

sawantpritam · 2022-03-30T13:21:42Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+    sltActions.clickSltPlugin();
+  }
+
+  @Then("Verify that after setting SLT parameter {string} as {string} plugin is throws error {string}")


Separate steps:

Enter SLT parameter {string} with value {string}

Verify SLT parameter validation error message {string} is displayed

sawantpritam · 2022-03-30T13:26:34Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+  }
+
+  @Then("Validate Replicate Existing Data can be set to false")
+  public void replicate_existing_data() {


->validateReplicateExistingDataState

Check all step definition's method names. Should align with step description

sawantpritam · 2022-03-30T13:29:02Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+    sltActions.clickNextButton();
+  }
+
+  @Then("Validate Table is available and  can be selected {string}")


No validation in this definition.

-> @then("Select table {string}")

sawantpritam · 2022-03-30T13:29:24Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+  }
+
+  @Then("Validate Table is available and  can be selected {string}")
+  public void select_table_something(String table) {


select_table_something -> selectTable

sawantpritam · 2022-03-30T13:31:35Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+  }
+
+  @Then("^Enter the BigQuery Properties for slt datasource$")
+  public void enter_the_bigquery_properties_for_slt_datasource_something() throws IOException {


_something ?

sawantpritam · 2022-03-30T13:34:00Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+    sltActions.enterDatasetName(pluginPropertyUtils.pluginProp("dataset"));
+  }
+
+  @Then("Validate Replication Pipeline can be deployed")


@then("Deploy replication pipeline")

sawantpritam · 2022-03-30T13:36:51Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+    sltLocators.logs.click();
+    parent = SeleniumDriver.getDriver().getWindowHandle();
+    tabs = new ArrayList(SeleniumDriver.getDriver().getWindowHandles());
+    SeleniumDriver.getDriver().switchTo().window((String) tabs.get(tabs.indexOf(parent) + 1));


Use PageHelper.switchToWindow

sawantpritam · 2022-03-30T13:40:05Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+    Assert.assertEquals(sapRecordsCount, bqRecordCount);
+  }
+
+  @Then("Verify that user is able to update table {string} to {string} on LTRC")


-> Verify that user is able to update table {string} to mode {string} on LTRC

sawantpritam · 2022-03-30T13:42:24Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+  }
+
+  @Then("Verify that user is able to update table {string} to {string} on LTRC")
+  public void slt_job_for_mtid_something_table_something_in_something_mode


add proper method name

sawantpritam · 2022-03-30T13:43:31Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+    Thread.sleep(10000); //sleep required to wait for async operation to be executed on SAP
+  }
+
+  @When("Fetche the record count of table : {string} from SAP")


sawantpritam · 2022-03-30T13:43:43Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+  }
+
+  @When("Fetche the record count of table : {string} from SAP")
+  public void user_fetches_the_record_count_of_table_something_from_sap(String table)


proper method name

sawantpritam · 2022-03-30T13:45:16Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+  }
+
+  @When("Validate that MTID can be Updated using CDF_R_SLT_SETTINGS program")
+  public void user_updates_mtid_in_program()


Check all step definition's method names. Should align with step description.
Applies to all

sawantpritam · 2022-03-30T13:46:21Z

e2e-test/java/io/cdap/plugin/slt/stepsdesign/StepDefinitionSLT.java

+  public static SLTActions sltActions = new SLTActions();
+  public static SLTLocators sltLocators = new SLTLocators();
+  public static String rawLog = null;
+  BigQueryClient bqClient = new BigQueryClient();


Remove instantiation

sawantpritam · 2022-03-30T13:53:59Z

e2e-test/features/DesignTimeSLT.feature

+    When Select SAP SLT as source
+    Then Validate SLT parameter "<option>" can be set as "<input>"
+    Examples:
+      | option            | input         |


Check all Examples table -> Update headers with Title Case

i.e option -> Option , input -> Input

sawantpritam · 2022-03-30T13:55:17Z

e2e-test/features/DesignTimeSLT.feature

+# the License.
+Feature: Design Time SLT Scenario
+
+  @SLT @Design-Time @Sanity


@SLT tag can be added on Feature instead of duplicating on each scenario.

sawantpritam · 2022-03-30T14:04:35Z

e2e-test/features/RunTimeSLT.feature

+    Given Open CDF replication and initiate pipeline creation
+    When Fetche the record count of table : "<table>" from SAP
+    Then Delete GCS folder for mass transfer id table "<table>"
+    Then Drop target BigQuery table "<table>"


Perform this as test prerequisite in @Before scenario

sawantpritam · 2022-03-30T14:07:38Z

Indent looks incorrect. Please reformat all files in the PR using this settings file - https://cdap.atlassian.net/wiki/spaces/CE/pages/1594098619/Coding+Standard

Indent still looks incorrect... check all files in PR

Updated :

ead1c5f

SLTActions.java SLTLocators.java StepDefinitionSLT.java

sawantpritam requested changes Mar 24, 2022

View reviewed changes

Updated as per review comments

4ca9455

harshit-google commented Mar 28, 2022

View reviewed changes

poojantcs reviewed Mar 28, 2022

View reviewed changes

Changes for remaining review comments

51feb9a

sawantpritam requested changes Mar 30, 2022

View reviewed changes


		public static By replicationStatus = By.xpath("//*[contains(text(),'replication status: Process: ')]");

		public static WebElement table (String tableName) {

		}


		@Given("^Open CDF replication and initiate pipeline creation")

Conversation

harshit-google commented Mar 24, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sawantpritam commented Mar 24, 2022

Uh oh!

sawantpritam commented Mar 24, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harshit-google left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!