Skip to content

fix: sanitize filter targets to prevent fuzzy search panic on binary data #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Castrozan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: sanitize filter targets to prevent fuzzy search panic on binary data #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions app/model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ package app

import (
"fmt"
"strings"
"time"
"unicode"

"github.com/charmbracelet/bubbles/help"
"github.com/charmbracelet/bubbles/key"
Expand Down Expand Up @@ -95,6 +97,7 @@ func NewModel() Model {
del := m.newItemDelegate()

clipboardList := list.New(entryItems, del, 0, 0)
clipboardList.Filter = sanitizedFilter
clipboardList.KeyMap = defaultOverrides(config.ClipseConfig.KeyBindings) // override default list keys with custom values
clipboardList.Title = clipboardTitle // set hardcoded title
clipboardList.SetShowHelp(false) // override with custom
Expand Down Expand Up @@ -127,6 +130,23 @@ func NewModel() Model {
return m
}

func sanitizedFilter(term string, targets []string) []list.Rank {
sanitized := make([]string, len(targets))
for i, t := range targets {
sanitized[i] = stripNonPrintable(t)
}
return list.DefaultFilter(term, sanitized)
}

func stripNonPrintable(s string) string {
return strings.Map(func(r rune) rune {
if unicode.IsPrint(r) {
return r
}
return -1
}, s)
}

// if isPinned is true, returns only an array of pinned items, otherwise all
func filterItems(clipboardItems []config.ClipboardItem, isPinned bool) []list.Item {
var filteredItems []list.Item
Expand Down