Skip to content

compiles but failing tests [FEATURE: handling alternate dtypes] #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jselvam11 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

compiles but failing tests [FEATURE: handling alternate dtypes] #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 63 additions & 65 deletions src/backend_scalar_c.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,106 +17,104 @@ struct LowerCtx
int indentation;
};

static void Lower_ScalarC(LowerCtx &ctx, const LoadIntImmediateInsn &i, size_t iinsn)
static void Lower_ScalarC(LowerCtx &ctx, const LoadIntImmediateInsn &i, size_t iinsn, NumericDataType dtype)
{
std::fprintf(ctx.file, "%*sint64_t v%zu = %" PRIi64 ";\n", ctx.indentation, " ", iinsn, i.value);
}

static void Lower_ScalarC(LowerCtx &ctx, const IntArithmeticInsn &i, size_t iinsn)
static void Lower_ScalarC(LowerCtx &ctx, const IntArithmeticInsn &i, size_t iinsn, NumericDataType dtype)
{
std::fprintf(ctx.file,
"%*sint64_t v%zu = v%zu %c v%zu;\n", ctx.indentation, " ", iinsn, i.x, (char)i.op, i.y);
}

static void Lower_ScalarC(LowerCtx &ctx, const BeginLoopInsn &i, size_t iinsn)
static void Lower_ScalarC(LowerCtx &ctx, const BeginLoopInsn &i, size_t iinsn, NumericDataType dtype)
{
std::fprintf(ctx.file, "%*sfor(int64_t v%zu = 0; v%zu < %zd; v%zu++)\n%*s{\n",
ctx.indentation, " ", iinsn, iinsn, i.range, iinsn, ctx.indentation, " ");
ctx.indentation += 4;
}

static void Lower_ScalarC(LowerCtx &ctx, const EndLoopInsn &i, size_t iinsn)
static void Lower_ScalarC(LowerCtx &ctx, const EndLoopInsn &i, size_t iinsn, NumericDataType dtype)
{
ctx.indentation -= 4;
std::fprintf(ctx.file, "%*s}\n", ctx.indentation, " ");
}

static void Lower_ScalarC(LowerCtx &ctx, const LoadInsn &i, size_t iinsn)
static void Lower_ScalarC(LowerCtx &ctx, const LoadInsn &i, size_t iinsn, NumericDataType dtype)
{
std::fprintf(ctx.file, "%*sfloat v%zu = i%zu[v%zu];\n",
ctx.indentation, " ", iinsn, i.input, i.idx);
std::fprintf(ctx.file, "%*s%s v%zu = i%zu[v%zu];\n",
ctx.indentation, " ", getCDatatype(dtype).c_str(), iinsn, i.input, i.idx);
}

static void Lower_ScalarC(LowerCtx &ctx, const StoreInsn &i, size_t iinsn)
static void Lower_ScalarC(LowerCtx &ctx, const StoreInsn &i, size_t iinsn, NumericDataType dtype)
{
std::fprintf(ctx.file, "%*soutput[v%zu] = v%zu;\n", ctx.indentation, " ", i.offset, i.value);
}

static void Lower_ScalarC(LowerCtx &ctx, const LoadImmediateInsn &i, size_t iinsn)
static void Lower_ScalarC(LowerCtx &ctx, const LoadImmediateInsn &i, size_t iinsn, NumericDataType dtype)
{
std::fprintf(ctx.file, "%*sfloat v%zu = %f;\n", ctx.indentation, " ", iinsn, i.value);
std::fprintf(ctx.file, "%*s%s v%zu = %f;\n", ctx.indentation, " ", getCDatatype(dtype).c_str(), iinsn, i.value);
}

static void Lower_ScalarC(LowerCtx &ctx, const UnaryInsn &i, size_t iinsn)
static void Lower_ScalarC(LowerCtx &ctx, const UnaryInsn &i, size_t iinsn, NumericDataType dtype)
{
auto op_str = i.type == UnaryOpType::EXP ? "exp"
: i.type == UnaryOpType::LOG ? "log"
: i.type == UnaryOpType::SIN ? "sin"
: i.type == UnaryOpType::SQRT ? "sqrtf"
: "INVALID";
std::fprintf(ctx.file, "%*sfloat v%zu = %s(v%zu);\n",
ctx.indentation, " ", iinsn, op_str, i.x);
auto op_str = i.type == UnaryOpType::EXP ? "exp"
: i.type == UnaryOpType::LOG ? "log"
: i.type == UnaryOpType::SIN ? "sin"
: i.type == UnaryOpType::SQRT ? "sqrtf"
: "INVALID";
std::fprintf(ctx.file, "%*s%s v%zu = %s(v%zu);\n",
ctx.indentation, " ", getCDatatype(dtype).c_str(), iinsn, op_str, i.x);
}

static void Lower_ScalarC(LowerCtx &ctx, const BinaryInsn &i, size_t iinsn)
static void Lower_ScalarC(LowerCtx &ctx, const BinaryInsn &i, size_t iinsn, NumericDataType dtype)
{
if(i.type == BinaryOpType::ADD
|| i.type == BinaryOpType::SUB
|| i.type == BinaryOpType::MUL
|| i.type == BinaryOpType::DIV
|| i.type == BinaryOpType::CMP)

if (i.type == BinaryOpType::ADD || i.type == BinaryOpType::SUB || i.type == BinaryOpType::MUL || i.type == BinaryOpType::DIV || i.type == BinaryOpType::CMP)
{
auto op_str = i.type == BinaryOpType::ADD ? "+"
: i.type == BinaryOpType::SUB ? "-"
: i.type == BinaryOpType::MUL ? "*"
: i.type == BinaryOpType::DIV ? "/"
: "==";

std::fprintf(ctx.file, "%*sfloat v%zu = (float)(v%zu %s v%zu);\n",
ctx.indentation, " ", iinsn, i.x, op_str, i.y);
auto op_str = i.type == BinaryOpType::ADD ? "+"
: i.type == BinaryOpType::SUB ? "-"
: i.type == BinaryOpType::MUL ? "*"
: i.type == BinaryOpType::DIV ? "/"
: "==";

std::fprintf(ctx.file, "%*s%s v%zu = (%s)(v%zu %s v%zu);\n",
ctx.indentation, " ", getCDatatype(dtype).c_str(), iinsn, getCDatatype(dtype).c_str(), i.x, op_str, i.y);
}
else if(i.type == BinaryOpType::MAX)
else if (i.type == BinaryOpType::MAX)
{
std::fprintf(ctx.file, "%*sfloat v%zu = v%zu > v%zu ? v%zu : v%zu;\n",
ctx.indentation, " ", iinsn, i.x, i.y, i.x, i.y);
std::fprintf(ctx.file, "%*s%s v%zu = v%zu > v%zu ? v%zu : v%zu;\n",
ctx.indentation, " ", getCDatatype(dtype).c_str(), iinsn, i.x, i.y, i.x, i.y);
}
else
{
std::fprintf(ctx.file, "%*sfloat v%zu = pow(v%zu, v%zu);\n",
ctx.indentation, " ", iinsn, i.x, i.y);
std::fprintf(ctx.file, "%*s%s v%zu = pow(v%zu, v%zu);\n",
ctx.indentation, " ", getCDatatype(dtype).c_str(), iinsn, i.x, i.y);
}
}

static void Lower_ScalarC(LowerCtx &ctx, const AccumulateInsn &i, size_t iinsn)
static void Lower_ScalarC(LowerCtx &ctx, const AccumulateInsn &i, size_t iinsn, NumericDataType dtype)
{
if(i.type == ReduceOpType::MAX)
if (i.type == ReduceOpType::MAX)
std::fprintf(ctx.file,
"%*sv%zu = v%zu > v%zu ? v%zu : v%zu;\n",
ctx.indentation, " ", i.accumulator, i.accumulator, i.x, i.accumulator, i.x);
else
std::fprintf(ctx.file, "%*sv%zu += v%zu;\n", ctx.indentation, " ", i.accumulator, i.x);
}

static void Lower_ScalarC(LowerCtx &ctx, const FunctionBuilder &fn, size_t ifn)
static void Lower_ScalarC(LowerCtx &ctx, const FunctionBuilder &fn, size_t ifn, NumericDataType dtype)
{
std::fprintf(ctx.file, "static void %s_%zu(\n", ctx.prefix, ifn);
for(size_t i = 0; i < fn.inputs.size(); i++)
std::fprintf(ctx.file, " const float *i%zu,\n", i);
std::fprintf(ctx.file, " float *output)\n{\n");
for (size_t i = 0; i < fn.inputs.size(); i++)
std::fprintf(ctx.file, " const %s *i%zu,\n", getCDatatype(dtype).c_str(), i);
std::fprintf(ctx.file, " %s *output)\n{\n", getCDatatype(dtype).c_str());
ctx.indentation = 4;
for(size_t i = 0; i < fn.insns.size(); i++)
for (size_t i = 0; i < fn.insns.size(); i++)
{
std::visit([&](auto &&insn) { Lower_ScalarC(ctx, insn, i); }, fn.insns[i]);
std::visit([&](auto &&insn)
{ Lower_ScalarC(ctx, insn, i, dtype); }, fn.insns[i]);
}
std::fprintf(ctx.file, "}\n\n");
}
Expand All @@ -127,11 +125,11 @@ static void GenerateMain(const Program &program, LowerCtx &ctx)
std::fprintf(ctx.file, "#if __linux__\n");
std::fprintf(ctx.file, " feenableexcept(FE_DIVBYZERO | FE_INVALID | FE_OVERFLOW);\n");
std::fprintf(ctx.file, "#endif\n");
for(size_t ifn = 0; ifn < program.functions.size(); ifn++)
for (size_t ifn = 0; ifn < program.functions.size(); ifn++)
{
const FunctionBuilder &fn = program.functions[ifn];
std::fprintf(ctx.file, " %s_%zu(\n", ctx.prefix, ifn);
for(size_t iinput = 0; iinput < fn.inputs.size(); iinput++)
for (size_t iinput = 0; iinput < fn.inputs.size(); iinput++)
std::fprintf(ctx.file, " buffers[%zu],\n", fn.inputs[iinput]);
std::fprintf(ctx.file, " buffers[%zu]);\n\n", fn.output_buffer);
}
Expand All @@ -146,45 +144,45 @@ static std::pair<GraphEvalFn, void *> CompileAndLoad(const std::filesystem::path
obj_path.replace_extension(".so");
std::string command =
"cc " +
source_path.string() +
source_path.string() +
" -o " +
obj_path.string() +
" -Ofast -fPIC -shared -lm -march=native -mtune=native";
std::system(command.c_str());
// std::printf("Compiling with: %s\n", command.c_str());

void *handle = dlopen(obj_path.c_str(), RTLD_NOW | RTLD_LOCAL);
if(!handle)
if (!handle)
throw std::runtime_error(dlerror());
dlerror(); // Clear error conditions
auto main_fn = reinterpret_cast<GraphEvalFn>(dlsym(handle, "gigagrad_main"));
if(!main_fn)
if (!main_fn)
{
char *err = dlerror();
if(!err)
if (!err)
throw std::runtime_error("Symbol gigagrad_main is NULL, which is unexpected");
else
throw std::runtime_error(err);
}
return { main_fn, handle };
return {main_fn, handle};
}

static std::pair<GraphEvalFn, void *> Lower_ScalarC(const char *prefix, const Program &program)
static std::pair<GraphEvalFn, void *> Lower_ScalarC(const char *prefix, const Program &program, NumericDataType dtype)
{
auto file_name = std::filesystem::temp_directory_path() / prefix;
file_name += ".c";
std::printf("FILE: %s\n", file_name.c_str());
FILE *file = std::fopen(file_name.c_str(), "w+");
if(!file)
if (!file)
throw std::system_error(errno, std::generic_category());

LowerCtx ctx = { prefix, file, 0 };
LowerCtx ctx = {prefix, file, 0};

std::fprintf(file, "#define _GNU_SOURCE\n#include <fenv.h>\n");
std::fprintf(file, "#include <stdint.h>\n#include <math.h>\n\n");

for(size_t ifn = 0; ifn < program.functions.size(); ifn++)
::Lower_ScalarC(ctx, program.functions[ifn], ifn);
for (size_t ifn = 0; ifn < program.functions.size(); ifn++)
::Lower_ScalarC(ctx, program.functions[ifn], ifn, dtype);

GenerateMain(program, ctx);
std::fclose(file);
Expand All @@ -194,31 +192,31 @@ static std::pair<GraphEvalFn, void *> Lower_ScalarC(const char *prefix, const Pr
BackendScalarC::~BackendScalarC()
{
dlclose(this->handle);
for(ssize_t ibuff = 0; ibuff < std::ssize(this->program.buffers); ibuff++)
for (ssize_t ibuff = 0; ibuff < std::ssize(this->program.buffers); ibuff++)
{
auto &desc = this->program.buffers[ibuff];
if(!std::holds_alternative<GraphNodeHandle>(desc.id))
if (!std::holds_alternative<GraphNodeHandle>(desc.id))
{
delete [] reinterpret_cast<float *>(this->buffers[ibuff]);
delete[] reinterpret_cast<float *>(this->buffers[ibuff]);
}
}
}

void BackendScalarC::LowerProgram(Program &&program)
{
this->program = std::move(program);
auto [eval_fn, handle] = Lower_ScalarC("gg_scalar", this->program);
auto [eval_fn, handle] = Lower_ScalarC("gg_scalar", this->program, NumericDataType::FLOAT32);
this->eval_fn = eval_fn;
this->handle = handle;
}

void *BackendScalarC::InitBuffers()
{
this->buffers.reserve(this->program.buffers.size());
for(ssize_t ibuff = 0; ibuff < std::ssize(this->program.buffers); ibuff++)
for (ssize_t ibuff = 0; ibuff < std::ssize(this->program.buffers); ibuff++)
{
auto &desc = this->program.buffers[ibuff];
if(std::holds_alternative<GraphNodeHandle>(desc.id))
if (std::holds_alternative<GraphNodeHandle>(desc.id))
{
GraphNodeHandle tensor = std::get<GraphNodeHandle>(desc.id);
this->buffers.push_back(reinterpret_cast<void *>(tensor.data()));
Expand All @@ -239,10 +237,10 @@ void *BackendScalarC::GetBuffer(size_t idx)

void BackendScalarC::Execute()
{
for(ssize_t ibuff = 0; ibuff < std::ssize(this->program.buffers); ibuff++)
for (ssize_t ibuff = 0; ibuff < std::ssize(this->program.buffers); ibuff++)
{
auto &desc = this->program.buffers[ibuff];
if(std::holds_alternative<GraphNodeHandle>(desc.id))
if (std::holds_alternative<GraphNodeHandle>(desc.id))
{
GraphNodeHandle tensor = std::get<GraphNodeHandle>(desc.id);
this->buffers[ibuff] = (reinterpret_cast<void *>(tensor.data()));
Expand Down
32 changes: 16 additions & 16 deletions src/backend_scalar_c.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,23 @@

namespace gigagrad
{
namespace codegen
{
namespace codegen
{

struct BackendScalarC : public Backend
{
using GraphEvalFn = void (*)(void **);
virtual ~BackendScalarC();
virtual void LowerProgram(Program &&program);
virtual void *InitBuffers();
virtual void *GetBuffer(size_t idx);
virtual void Execute();
struct BackendScalarC : public Backend
{
using GraphEvalFn = void (*)(void **);
virtual ~BackendScalarC();
virtual void LowerProgram(Program &&program);
virtual void *InitBuffers();
virtual void *GetBuffer(size_t idx);
virtual void Execute();

void *handle;
Program program;
std::vector<void *> buffers;
GraphEvalFn eval_fn;
};
void *handle;
Program program;
std::vector<void *> buffers;
GraphEvalFn eval_fn;
};

}
}
}
Loading