Conversation
|
I've implemented #82 on my end and I :
How is this PR different ? BTW : This PR also changes the default sample rate. |
No, it's the same, you're right, I had not seen there was already a PR implementing this.
It does not, if you look at "Files Changed" |
src/config.yaml
Outdated
| min_duration: 100 | ||
| recording_mode: press_to_toggle | ||
| sample_rate: 32000 | ||
| sample_rate: 16000 |
There was a problem hiding this comment.
I might be a GitHub noob, but this looks like a sample rate change, isn't it?
There was a problem hiding this comment.
Yeah, it's only the commit. The overall diff doesn't change it.
|
I don't know why this would need to be an option at all. When you need the settings, you can get to them via the tray icon. |
I think there's not much use in showing the main window every time, and not start listening right away. Even more so when the settings are always easily accessible via the tray icon.
Having the option to hide the main window enables, for example, running WhisperWriter at OS startup and start listening immediately to the hotkey, instead of compulsorily seeing the window every time.