chore: headless server handles null input instead of closing immediately#8
Open
eliot-portevin wants to merge 1 commit intosauterl:masterfrom
Open
chore: headless server handles null input instead of closing immediately#8eliot-portevin wants to merge 1 commit intosauterl:masterfrom
eliot-portevin wants to merge 1 commit intosauterl:masterfrom
Conversation
Spiess
approved these changes
Aug 14, 2024
Collaborator
Spiess
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Is there any way to prevent the headless server from exiting when run with ProcessBuilder while preserving ctrl-D exit behavior?
If not this is fine, but if there was a way to keep this in that would be preferable.
Author
|
According to stackoverflow, CTRL+D sends an EOF signal to the command line. I'm not aware of how we could differentiate this from a null input, but since the game already takes a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the jar using ProcessBuilder resulted in an immediate exit of the game. This was due to the fact that the Scanner in the headless server detected no input and therefore decided to exit.
Note: when a player exits their lobby, the server receives several NullPointerExceptions because player.getLobby() is null. The game still works though.
Note 2: the gradle version was changed to 8.5 to work with java 21, this mustn't stay as such