file handle fixes#26
Open
retrohead wants to merge 54 commits intosatiator:masterfrom
retrohead:master
Open
Conversation
retrohead
commented
Feb 24, 2021
retrohead
commented
- Opening output file in iso2desc. If stat fails on the input file, the output file was left open. Don't bother opening output file until after the stat.
- cue2desc failing on looking for data chunk was leaving the output file open.
- I can't compile this to test it, sorry
Author
|
Found some more errors in the FS functions, no way to distinguish errors for 19 bytes as the enum value for the error is 19. Returned it as a negative instead. |
rebase to master
[skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.