Configure Specific AI Gateway and Model instead of direct model providers #7
Open
sathish316 wants to merge 6 commits intomainfrom
Open
Configure Specific AI Gateway and Model instead of direct model providers #7sathish316 wants to merge 6 commits intomainfrom
sathish316 wants to merge 6 commits intomainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| base_url = model_config.get("base_url") | ||
| timeout = int(model_config.get("timeout", 300)) | ||
| client = AsyncOpenAIAIGatewayClient( | ||
| base_url=base_url + "/v1/openai/v1", |
There was a problem hiding this comment.
Bug: Missing base_url causes TypeError during string concatenation
When base_url is not provided in the model config, model_config.get("base_url") returns None, and the subsequent string concatenation base_url + "/v1/openai/v1" raises a TypeError. Unlike the timeout parameter which has a default value, base_url lacks validation or a fallback, resulting in a confusing runtime error instead of a clear configuration error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved for Issue #6
Note
Introduces an OpenAI-compatible AI Gateway client/provider and wires it into the model manager, with a cookbook detailing gateway configuration.
AsyncOpenAIAIGatewayClientto inject custom headers from env and route requests viabase_url + "/v1/openai/v1".OpenAIAIGatewayProviderto build/configure the gateway client forOpenAIChatModel.ModelManagerto initialize models withprovider: "gateway"viainitialize_ai_gateway_model().docs/COOKBOOK.mdwith steps to configure env vars and YAMLmodel_configfor connecting to an AI Gateway.Written by Cursor Bugbot for commit 94e46b2. This will update automatically on new commits. Configure here.