Skip to content

Conversation

@tmoody
Copy link
Member

@tmoody tmoody commented Dec 10, 2025

Issue

Tests are using an end-of-life version of Node.

@sasjs/cli does not reference the @sasjs/core branch under test during the test workflow.

Intent

Use the oldest supported version of Node for testing.

Set environment variable macroCorePath to direct @sasjs/cli to use the installation of @sasjs/core at the path provided in that variable. The variable is set to . to denote the current directory which, at time of execution, is the root folder of the @sasjs/core branch being tested.

Implementation

run-tests.yml: amended node-version from [lts/hydrogen] to [lts/iron].

run-tests.yml: amended

      - name: Build & Deploy Project to SAS server
        run: npx @sasjs/cli cbd -t server

becomes

      - name: Build & Deploy Project to SAS server
        run: npx @sasjs/cli cbd -t server
        env:
          macroCorePath: .

Checks

  • Code is formatted correctly (sasjs lint).
  • Any new functionality has been unit tested.
  • All unit tests are passing (sasjs test).
  • The PR desc or underlying commits follow the Conventional Commit standard

@tmoody tmoody self-assigned this Dec 10, 2025
@tmoody tmoody changed the title fix(test): bumped Node to lts/iron (v20.x.x) for tests DRAFT: fix(test): bumped Node to lts/iron (v20.x.x) for tests Dec 10, 2025
@tmoody tmoody marked this pull request as draft December 10, 2025 17:29
@tmoody tmoody marked this pull request as ready for review December 16, 2025 13:40
@tmoody tmoody changed the title DRAFT: fix(test): bumped Node to lts/iron (v20.x.x) for tests fix(test): bumped Node to lts/iron (v20.x.x) for tests Dec 16, 2025
@tmoody tmoody merged commit 641966e into main Dec 16, 2025
1 check passed
@tmoody tmoody deleted the bumpNodeVersionForTest branch December 16, 2025 15:03
@github-actions
Copy link

🎉 This PR is included in version 4.59.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants