Skip to content

Conversation

@tmoody
Copy link
Member

@tmoody tmoody commented Nov 27, 2025

Issues

  1. mp_stripdiffs.sas does not find the mp_ds2squeeze.sas macro dependency because it is not listed in the correct section.

  2. The compile of test programs that utilise cross-platform macros fail due to sasjsconfig.json macroFolder settings that limit the visibility of the dependent macros for individual server-types.

Intent

  1. Correct the placement of the mp_stripdiffs.sas dependency within the header.

  2. Make all platform macros available to the sasjs compilation stage.

Implementation

  1. Relocated the @li mp_ds2squeeze.sas dependency to the correct header section in mp_stripdiffs.sas.

  2. sasjsconfig.json - the global macroFolders[ ] array now includes all platforms so that x-platform testing macros will successfully compile.

Checks

  • Code is formatted correctly (sasjs lint).
  • Any new functionality has been unit tested.
  • All unit tests are passing (sasjs test).
  • The PR desc or underlying commits follow the Conventional Commit standard

@tmoody tmoody self-assigned this Nov 27, 2025
@tmoody tmoody requested a review from allanbowe November 27, 2025 15:20
@allanbowe allanbowe merged commit 66ceb73 into main Nov 27, 2025
1 check passed
@allanbowe allanbowe deleted the mp_stripdiff_fix branch November 27, 2025 15:28
@github-actions
Copy link

🎉 This PR is included in version 4.59.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants