Fix widget tests to compare text content instead of Finder equality#13
Open
cubic-dev-ai[bot] wants to merge 1 commit intosarahwithanhwilson-patch-2from
Open
Fix widget tests to compare text content instead of Finder equality#13cubic-dev-ai[bot] wants to merge 1 commit intosarahwithanhwilson-patch-2from
cubic-dev-ai[bot] wants to merge 1 commit intosarahwithanhwilson-patch-2from
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finderobjects instead of actual widget text contentexpect(firstGame, firstGameAfterChange)which comparedFinderequality rather than verifying the actual game text changedChanges
'deletes game in show schedule'test to extract and compare text content'generates new game'test to extract and compare text content'replaces game and then gets new show'test to extract and compare text contentisNot()to properly test replacement behaviorTest plan
flutter test test/widget_test.dartto verify all tests pass🤖 Generated with Claude Code
Summary by cubic
Fixed widget tests to assert text content changes instead of comparing Finder objects, ensuring user interactions are verified correctly. Updated three tests to read Text.data and use isNot for replacement checks.
Written for commit 2202191. Summary will update on new commits.