fix: add stopword filtering and overlap ratio to roleMatch (#157)#194
Closed
SAY-5 wants to merge 1 commit intosantifer:mainfrom
Closed
fix: add stopword filtering and overlap ratio to roleMatch (#157)#194SAY-5 wants to merge 1 commit intosantifer:mainfrom
SAY-5 wants to merge 1 commit intosantifer:mainfrom
Conversation
…tifer#157) roleMatch() was treating location words (tokyo, japan) and generic seniority words (lead, manager, director) as role-identifying, causing false-positive dedup matches that silently destroyed distinct entries. Add ROLE_STOPWORDS set and require overlap to be both ≥2 content words AND ≥60% of the shorter title's content words. Verified against all 8 test cases from issue santifer#157.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds stopword filtering and an overlap ratio threshold to roleMatch to reduce false positives. Previously, common words like "senior" or "engineer" could inflate match scores between unrelated roles.