fix: keep TableMenu dialog input controlled #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

mehmetyildizdev wants to merge 1 commit into sanity-io:main from mehmetyildizdev:fix/tablemenu-controlled-input

+17 −6

mehmetyildizdev commented Nov 2, 2025

Description

Ensure the TableMenu dialog TextInput is always controlled by initializing count as an empty string and resetting it when the dialog opens/closes.
Silences the React controlled/uncontrolled warning and keeps the dialog input consistent.

What to review

Open the Table menu, trigger each “Add …” action, and confirm the dialog input remains editable without console warnings.
Double-check the confirm handler still submits the entered value correctly.

Testing

Manually tested by opening each dialog, typing values, cancelling, and confirming to verify no warnings and correct behavior.


          fix(table-menu): keep TextInput controlled

5b78d94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet