This repository was archived by the owner on Feb 12, 2026. It is now read-only.
Feat/support referencing translations that sit in a release#211
Open
SamHemingway wants to merge 2 commits intomainfrom
Open
Feat/support referencing translations that sit in a release#211SamHemingway wants to merge 2 commits intomainfrom
SamHemingway wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As it stands, if we have a translation metadata document that refers to a translated document that sits in a release, we get a validation error.
The validation logic currently checks the published or draft perspectives.
This PR lets the validation use the
rawperspective, so it can validate against versioned documents too.What to review
Is this going to break anything unexpected? It should purely be additive.
Also, the experience on the translations metadata document is confusing when looking at the published perspective:
But makes sense when you're looking at the perspective in which the translation exists: